Bug 2172 - RSSyl plugin insists on creating unnecessary directories
Summary: RSSyl plugin insists on creating unnecessary directories
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Plugins/RSSyl (show other bugs)
Version: 3.7.2
Hardware: PC Linux
: P3 minor
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2010-04-17 14:07 UTC by Michael Orlov
Modified: 2018-12-30 00:41 UTC (History)
0 users

See Also:


Attachments

Description Michael Orlov 2010-04-17 14:07:27 UTC
If a feed is renamed, RSSyl still insists on creating directories (in claws-mail/RSSyl) according to the "text"/"description" attributes in rssyl-feedlist.opml instead of the "title" attribute (alternatively - according to "official_name" attribute instead of "name" in feeds.xml).

This happens during feeds refreshing.

This can be problematic when, e.g., feed's official name has non-ASCII characters, and directory synchronization mechanism that doesn't tolerate such characters is used.
Comment 1 Andrej Kacian 2010-04-17 16:37:57 UTC
I'm not sure I understand.

When a feed is renamed, the original name is stored in the "official_name" attribute, to be able to rename the RSSyl folder if the source feed title changes (I haven't seen this happen in a real world feed as of yet, but hey). The folder (together with the folder in the underlying filesystem) gets renamed to the new name.

"rssyl-feedlist.opml" is a file that is generated from existing feeds, and RSSyl doesn't read from it or care about it in any way.

Are you suggesting that when you refresh the feed after the rename, the updates go to the old folder (which shouldn't even be there) ?
Comment 2 Michael Orlov 2010-04-17 17:07:13 UTC
> "rssyl-feedlist.opml" is a file that is generated from existing feeds, and RSSyl doesn't read from it or care about it in any way.

OK, that's why I mentioned both OPML and XML files - wasn't sure which is primary and which is secondary.

> Are you suggesting that when you refresh the feed after the rename, the updates go to the old folder (which shouldn't even be there) ?

No, the updates go to the new folder, but the empty old folder gets recreated in the file system, at least in my setup (Gentoo). It's easy to test, just rename a feed, and do "refresh all feeds".
Comment 3 Andrej Kacian 2010-04-17 17:15:02 UTC
I see, thanks for clarifying. I will look into it.
Comment 4 Andrej Kacian 2018-12-30 00:41:34 UTC
This was "fixed" by the plugin rewrite back in 2014, closing.

Note You need to log in before you can comment on or make changes to this bug.