Summary: | Mark all as read/unread does not belong to the message context menu | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Claws Mail (GTK 2) | Reporter: | Jean Delvare <jdelvare> | ||||||||
Component: | UI/Message List | Assignee: | users | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | normal | ||||||||||
Priority: | P3 | ||||||||||
Version: | 3.17.3 | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
Jean Delvare
2019-11-21 09:54:31 UTC
You can enable "Confirm when marking all messages as read or unread" in Summaries page of preferences. Created attachment 2027 [details]
Candidate fix for problem #1
That's the change I would want, addressing problem #1. Implementing the confirmation dialog (problem #2) is unfortunately way beyond my GTK skills.
The confirmation dialogue is already present, and enabled by default. When it is the context menu it means it can be applied to just the selected messages. Leaving as INVALID. Thank you very much Ricardo. I could not find it without your help, as its position within the Preferences is not exactly obvious. Or maybe I'm just not smart enough ;-) Either way this addresses problem #2, which is great. Problem #1 remains though. I still believe the "Mark all read/unread" entries should be removed from the message menus. I have attached a candidate patch doing exactly that, please consider applying it. Again as a comparison point Evolution does not have such entries there. It does have "Folder > Mark All Messages as Read", because that's where such an action belongs. I'll attach another patch adding the "Mark all read" and "Mark all unread" entries to a new Folder top-level menu item. Hopefully this addresses any accessibility concern. > The confirmation dialogue is already present, and enabled by default. I'm a long-time Claws user so it is entirely possible that I disabled this years ago, although I do not remember doing it and I usually don't disable such safeties. Anyway that part of the problem is solved, thanks. > When it is the context menu it means it can be applied to just the > selected messages. I don't follow you. Selecting multiple messages then doing "Right click > Mark > Mark as read/unread" will do the right thing. "Right click > Mark > Mark all as read/unread" does not depend on the message selection at all. Created attachment 2028 [details]
[PATCH 2/2] Add a Folder menu entry with Mark all read/unread
This on top of the other patch makes the UI consistent (in my opinion, at least) and in line with what other MUA like Evolution are doing.
> I don't follow you.
You're right. I wasn't really concentrating. :)
Created attachment 2031 [details]
[PATCH 1/2 v2] Remove "Mark all read/unread" from the message context menu
Changes since v1:
* Removed SET_SENSITIVE calls on the removed menu entries.
Please allow me to reopen this. I think that this bug was closed because my second concern ("Mark all messages as read" not asking for confirmation) was invalid. However my first point about the UI consistency was never discussed. I still believe that "Mark all messages as read/unread" does not belong to the Message-related context menu and should be removed from there. Would you please consider doing that (that is, applying patch 1)? The same action is already available in the Folder-related context menu (where it belongs). Patch 2 (Adding a Folder top-level menu entry) is optional, it's not strictly needed but should be considered if you want users to be able to do the same without using the right mouse button. More actions could be added to that menu later if you think that would be convenient. For what it's worth, both patches were accepted in the openSUSE build of claws-mail: https://build.opensuse.org/package/show/openSUSE:Factory/claws-mail Thanks. > [PATCH 2/2] Add a Folder menu entry with Mark all read/unread
For me, this patch makes no more sense than what your other patch removes.
Actions relating to folders are in the folder's context menu (Mark all read/unread are already there). Your new menu entry contains just those 2 and doesn't include all the rest. Therefore it can only be rejected.
On the other hand, removing those items from the summaryview context menu does make some sense, and we have been discussing that.
Thanks all the same! We will continue to discuss the case for the removal from the summaryview context menu and come to a decision.
The fact that the patches have been accepted by OpenSUSE is just a bad decision on their part, imo.
> Actions relating to folders are in the folder's context menu (Mark all > read/unread are already there). Your new menu entry contains just those 2 > and doesn't include all the rest. Therefore it can only be rejected. Yeah, as I was writing my comment this morning, the idea crossed my mind that if there was to be a Folder entry in the top menu then it would have to contain a lot more commands to make sense. I agree with you that the second patch can't be applied as is. > The fact that the patches have been accepted by OpenSUSE is just a bad decision > on their part, imo. Probably not my best move, but I wanted my problem solved in a reasonable time frame. I'll get the second patch removed there as it's not going to make it upstream. Thanks for your time. |