Summary: | Switching folders is slow | ||
---|---|---|---|
Product: | Claws Mail (GTK 2) | Reporter: | Alexander Harkness <me> |
Component: | Folders/IMAP | Assignee: | users |
Status: | NEW --- | ||
Severity: | normal | ||
Priority: | P3 | ||
Version: | 3.17.5 | ||
Hardware: | All | ||
OS: | All | ||
Attachments: |
Description
Alexander Harkness
2019-08-29 15:50:19 UTC
Just to correct your "no cache" assertion: before opening a folder, Claws Mail queries the server about list of UID numbers of messages it contains ("UID FETCH 1:* (FLAGS UID)"), and compares it to its local cache. After that, only additional information about messages with previously unseen UIDs is being retrieved. As for your patches, we'll be happy to see any improvements regarding this. Created attachment 2001 [details]
Patch to add tests for subject_get_prefix_length
Created attachment 2002 [details]
Patch to improve performance of subject_get_prefix_length
Created attachment 2003 [details]
Patch to remove check for duplicate message IDs in threading process
> Just to correct your "no cache" assertion: before opening a folder, Claws Mail queries the server about list of UID numbers of messages it contains ("UID FETCH 1:* (FLAGS UID)"), and compares it to its local cache. After that, only additional information about messages with previously unseen UIDs is being retrieved.
This is indeed the case, the folder rebuilding I was referring to is after the imapcache is loaded (and the remote server scanned against it) - much CPU time is spent converting the imapcache into summaryview form, only for this to be wasted by free() as soon as the user switches to viewing a different folder.
I have attached 3 patches (one is simply a test to ensure I haven't changed behaviour unintentionally).
Created attachment 2004 [details]
Patch to eliminate duplicate insertions to subject hash table
Any chance this could get a review? |