Summary: | Select folder dialogue does not tell what is selecting for | ||||||
---|---|---|---|---|---|---|---|
Product: | Claws Mail (GTK 2) | Reporter: | Ricardo Mones <mones> | ||||
Component: | UI | Assignee: | users | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | enhancement | ||||||
Priority: | P3 | ||||||
Version: | 3.13.2 | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Ricardo Mones
2015-12-21 13:30:15 UTC
Created attachment 1687 [details]
Possible fix
A candidate fix for this: just adds a parameter to the function for specifying the dialogue title. A few callbacks are reused and still share default title, but since the trigger buttons are in the same window (and likely to be configured in a row) and the duplication of code it would require, makes separation effort not worth enough IMO.
Review of the English grammar in titles is welcome, though it can also be done after pushing, of course :-)
Thumbs up on this one. :) Changes related to this bug have been committed. Please check latest Git and update the bug accordingly. You can also get the patch from: http://git.claws-mail.org/ ++ ChangeLog 2017-03-16 19:17:03.160766050 +0100 http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=a6b0c1e0850def82a2adae4090b30567c4ef6e1e Merge: 7ca5f5c bd8213f Author: Colin Leroy <colin@colino.net> Date: Thu Mar 16 19:17:02 2017 +0100 Merge branch 'master' of file:///home/git/claws http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=bd8213fe3d3ca5da043992520e96f07aacd0d443 Author: Andrej Kacian <ticho@claws-mail.org> Date: Thu Mar 16 19:14:49 2017 +0100 Allow custom window title for the folder selection dialog. Fixes bug #3582 - Select folder dialogue does not tell what is selecting for. http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=e420063586f5117a00c3460ed074e34c95709ff9 Author: Andrej Kacian <ticho@claws-mail.org> Date: Thu Mar 16 18:37:30 2017 +0100 Added summary_get_selection_count() function. These dialogs will now have titles like "Select folder to copy selected message to". |