| Summary: | autoconfiguration: get more detailed error message | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Claws Mail (GTK 2) | Reporter: | Christian Hesse <mail> | ||||||||
| Component: | Other | Assignee: | users | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | minor | ||||||||||
| Priority: | P3 | ||||||||||
| Version: | 3.13.0 | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Christian Hesse
2015-09-28 14:42:37 UTC
Created attachment 1570 [details]
autoconfiguration: get more detailed error message
While idea is not bad, current patch prints an untranslated string (the raw error message) in the middle of a translated string. For non-english users it will be a poor translation, and won't help much either since they won't understand the error message itself. IMHO, either you get the possible error codes and write the appropriate message for each one of them (so translators can translate) or just do a g_warning with the error message if all you want is additional info printed somewhere. (In reply to comment #2) > While idea is not bad, current patch prints an untranslated string (the raw > error message) in the middle of a translated string. > > For non-english users it will be a poor translation, and won't help much > either since they won't understand the error message itself. > > IMHO, either you get the possible error codes and write the appropriate > message for each one of them (so translators can translate) Good point. I will update the patch. Not a big deal as we have to handle just two error codes. > or just do a > g_warning with the error message if all you want is additional info printed > somewhere. With g_warning this is printed to console? Possibly we should log errors (and success?) to network log. Is it ok to have untranslated strings there? Created attachment 1572 [details]
autoconfiguration: get more detailed error message
Let's use error code instead of error message...
Created attachment 1576 [details]
autoconfiguration: log to network log
(In reply to comment #5) > Created attachment 1576 [details] > autoconfiguration: log to network log Umm, I've just made a simpler patch based on your second one which I'll probably apply tonight. Once applied I don't think logging to network log is required for this, as errors are going to be seen on the interface anyway. Sorry for not being able to answer before ;-) Changes related to this bug have been committed. Please check latest Git and update the bug accordingly. You can also get the patch from: http://git.claws-mail.org/ ++ ChangeLog 2015-10-01 22:07:02.186306990 +0200 http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=bfec412f69678d4d696e2c6397b7f6660e8e2f53 Merge: 16faf31 e6aa883 Author: Colin Leroy <colin@colino.net> Date: Thu Oct 1 22:07:01 2015 +0200 Merge branch 'master' of file:///home/git/claws http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=e6aa8837949636cb1c8540074b87e26907022c05 Author: Ricardo Mones <ricardo@mones.org> Date: Wed Sep 30 23:17:41 2015 +0200 Fix bug #3526 ‘autoconfiguration: get more detailed error message’ Based on original patch by Christian Hesse (thanks!). |