Bug 3112

Summary: Non-ASCII characters in string
Product: Claws Mail (GTK 2) Reporter: Christian Hesse <mail>
Component: PluginsAssignee: users
Status: RESOLVED FIXED    
Severity: normal    
Priority: P3    
Version: 3.10.0   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
replace non ASCII-characters
none
allow UTF-8 charaters in translatable strings none

Description Christian Hesse 2014-03-17 20:17:53 UTC
Created attachment 1349 [details]
replace non ASCII-characters

Compilation fails because of non-ASCII characters in string:

/usr/bin/xgettext: Non-ASCII string at src/plugins/libravatar/libravatar.c:438.
                   Please specify the source encoding through --from-code.
Makefile:400: recipe for target 'claws-mail.pot-update' failed

Patch is attached.
Comment 1 Paul 2014-03-18 11:02:30 UTC
thanks for the patch!
Comment 2 Ricardo Mones 2014-03-18 18:30:46 UTC
Despite the first diff is correct (because it's how menu path references are usually written within the project), the quotes (or other UTF-8 char) should represent no problem, so fallback to ASCII is not the right fix.

Proposal is to add "--from-code=UTF-8"¹ to XGETTEXT_OPTIONS in po/Makevars.

¹http://linux.die.net/man/1/xgettext
Comment 3 Christian Hesse 2014-03-18 19:47:43 UTC
Created attachment 1351 [details]
allow UTF-8 charaters in translatable strings

Like this? Looks like it compiles fine.