| Summary: | address completion with gpg keyring | ||
|---|---|---|---|
| Product: | Claws Mail (GTK 2) | Reporter: | Christian Hesse <mail> |
| Component: | UI/Compose Window | Assignee: | users |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | ||
| Priority: | P3 | ||
| Version: | 3.9.0 | ||
| Hardware: | All | ||
| OS: | All | ||
| Attachments: | |||
|
Description
Christian Hesse
2013-01-27 20:13:58 UTC
Created attachment 1321 [details]
add plugin for GPG addresses autocompletion
I found some time to take a look at this...
This plugin works perfectly. I hope I did got the build system things right.
Created attachment 1322 [details]
add plugin for GPG addresses autocompletion
Damn, I broke linking... Should work now.
Created attachment 1323 [details]
add plugin for GPG addresses autocompletion
This had some rough edges... Reworked it a bit.
This plugin depends on newmail plugin? src/plugins/gpgaddress/Makefile.am: if BUILD_NEWMAIL_PLUGIN plugin_LTLIBRARIES = gpgaddress.la endif Uh, no, it does not. Just a copy'n'paste error. Will upload a new patch. Created attachment 1324 [details]
add plugin for GPG addresses autocompletion
Fixed the copy'n'paste error.
Created attachment 1342 [details]
add plugin for GPG addresses autocompletion
Update to apply for latest git.
Created attachment 1346 [details]
add plugin for GPG addresses autocompletion
Clean up header files and add temporary binary files to .gitignore.
Hi, This is actually a very good idea! I do wonder if it is necessary to add it as a new plugin. I think the functionality could be integrated into the PGP/Core plugin. (We often add plugins when they add requirements or dependancies, and this one doesn't) What do you think ? Thanks for your work! Sure, we could do this. I will move the code and prepare a new patch. I will add a new configuration option for whether oder not auto completion for GPG keyring should be enabled. What is the preferrer default? Off by default would be better :) Created attachment 1347 [details]
add keyring address autocompletion support to PGP/Core plugin
New patch: Add keyring address autocompletion support to PGP/Core plugin.
Created attachment 1348 [details]
add keyring address autocompletion support to PGP/Core plugin
Fix whitespace in plugin description.
Changes related to this bug have been committed. Please check latest Git and update the bug accordingly. You can also get the patch from: http://git.claws-mail.org/ ++ ChangeLog 2014-03-17 15:01:02.932796940 +0100 http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=736c1a8a599a720c2dce5387284d6b630b702d52 Merge: 1e7f2c2 764fcdc Author: Colin Leroy <colin@colino.net> Date: Mon Mar 17 15:01:02 2014 +0100 Merge branch 'master' of file:///home/git/claws http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=764fcdc60bd2c0c717bf699f13d45eb23de99031 Author: Colin Leroy <colin@colino.net> Date: Mon Mar 17 14:59:54 2014 +0100 Fix crash due to wrong use of the gpointer source (which is a pointer-to-pointer to GList), replace exit() with return. http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=faf5411f3c7b7a76950d91b232072eb98857988a Author: Colin Leroy <colin@colino.net> Date: Mon Mar 17 14:56:15 2014 +0100 Add the GPG keyring as possible source for address autocompletion. Patch by Christian Hesse, fixes bug #2868. This has been applied some time ago. Thanks! |