Bug 4023 - Fix some small issues
Summary: Fix some small issues
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Other (show other bugs)
Version: 3.17.0
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2018-05-04 16:34 UTC by Avinash Sonawane
Modified: 2018-05-26 10:22 UTC (History)
0 users

See Also:


Attachments
patch-1 (2.87 KB, patch)
2018-05-04 16:34 UTC, Avinash Sonawane
no flags Details | Diff
patch-2 (2.37 KB, patch)
2018-05-04 16:36 UTC, Avinash Sonawane
no flags Details | Diff

Description Avinash Sonawane 2018-05-04 16:34:12 UTC
Created attachment 1870 [details]
patch-1

Hello!

Please find the attached patches which aim to fix some small issues like declaring variable and functions only if they are needed (using #ifndef), using fabs() instead of abs() for `double` argument etc.

Please let me know if something needs to be fixed/amended.

Regards,
Avinash Sonawane (rootKea)
PICT, Pune
https://rootkea.wordpress.com
Comment 1 Avinash Sonawane 2018-05-04 16:36:10 UTC
Created attachment 1871 [details]
patch-2

Patch #2
Comment 2 users 2018-05-26 10:22:04 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2018-05-26 12:22:04.273480674 +0200
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=961a070edcc5d733038cfc9569caf202c96882d1
Merge: b10173a b0460fa
Author: Colin Leroy <colin@colino.net>
Date:   Sat May 26 12:22:03 2018 +0200

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=b0460fa371588d774e6c120b19b90f7d7b724a55
Author: Paul <paul@claws-mail.org>
Date:   Sat May 26 11:21:19 2018 +0100

    fix bug #4023, 'Fix some small issues'
    
    * src/common/plugin.c: Remove redundant 'const' qualifier
    * src/jpilot.c: Remove redundant parentheses
    * src/mbox.c: Likewise
    * src/procmsg.c: Use fabs instead of abs for 'double' arg
    * src/ textview.c: Declare 'shortcut' only if not GENERIC_UMPC
    * src/toolbar.c: Declare 'toolbar_reply_menu_cb()' and
    'toolbar_delete_dup_menu_cb' only if not GENERIC_UMPC
    
    Patch by Avinash Sonawane
Comment 3 Paul 2018-05-26 10:22:37 UTC
thanks!

Note You need to log in before you can comment on or make changes to this bug.