Bug 3981 - Undo does not restore quoted text color
Summary: Undo does not restore quoted text color
Status: NEW
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: UI/Compose Window (show other bugs)
Version: 3.16.0
Hardware: PC Linux
: P3 trivial
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2018-03-05 23:38 UTC by George
Modified: 2019-04-08 19:56 UTC (History)
0 users

See Also:


Attachments
screencast (464.70 KB, application/x-7z-compressed)
2018-03-05 23:40 UTC, George
no flags Details
color quotes in compose window after an undo or paste (6.98 KB, patch)
2019-04-08 19:56 UTC, Martin Kunev
no flags Details | Diff

Description George 2018-03-05 23:38:53 UTC
STR:

1. Open to edit some message containing quoted text.
2. Delete some of the colored quoted text
3. Undo

EXPECTED:
Quoted text should be colored properly after Undo

ACTUAL:
All text restored through Undo is the same default color.

Attaching a screencast
Comment 1 George 2018-03-05 23:40:24 UTC
Created attachment 1851 [details]
screencast
Comment 2 George 2018-03-05 23:45:04 UTC
P.S. As it can be seen on the video, after inserting a line before the restored quoted text the colors are restored but not before that.
Comment 3 Martin Kunev 2019-04-05 17:56:45 UTC
The reason for this behavior is that after a change claws updates the colors just for the paragraph following the cursor. As the undo command puts the cursor at the end, the colors are not updated.
Comment 4 Martin Kunev 2019-04-08 19:56:43 UTC
Created attachment 1972 [details]
color quotes in compose window after an undo or paste

I'm attaching a patch. Please give me feedback if anything needs improvement.

Patch description:
Properly color quotes in compose window after an undo or paste action.

Note You need to log in before you can comment on or make changes to this bug.