Bug 3680 - GnuTLS support broken after recent commits
Summary: GnuTLS support broken after recent commits
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Other (show other bugs)
Version: 3.14.1
Hardware: PC Linux
: P3 critical
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2016-08-24 23:45 UTC by glitsj16
Modified: 2016-08-25 10:49 UTC (History)
0 users

See Also:


Attachments

Description glitsj16 2016-08-24 23:45:48 UTC
Recent commits

    *  http://git.claws-mail.org/?p=claws.git;a=commit;h=61bced3dfe1b5bfcfa512fcc5e0c35fd163d8ac0
    * http://git.claws-mail.org/?p=claws.git;a=commit;h=b88c772b96c2c0cce11fbf1012806bd11d6b1452

seem to have broken SSL/TLS support. Seeing the below both on Arch Linux and Ubuntu 16.04, using claws-mail build from git. Reverting the above commits brings things back to 'normal'.
 
$ lsb_release -d
Description:	Arch Linux

$ pacman -Qi claws-mail-git | grep Version
Version         : 3.14.0.r29.g6298f43-1

$ pacman -Qi gnutls | grep Version
Version         : 3.4.14-1

$ claws-mail

** (claws-mail:28114): WARNING **: SSL connection failed (No or insufficient priorities were set.)

** (claws-mail:28114): WARNING **: can't initialize SSL.

** (claws-mail:28114): WARNING **: [22:22:50] SSL handshake failed

** (claws-mail:28114): WARNING **: SSL connection failed (No or insufficient priorities were set.)

** (claws-mail:28114): WARNING **: couldn't start TLS session.

** (claws-mail:28114): WARNING **: [22:23:00] Socket error.


Regards.
Comment 1 Andrej Kacian 2016-08-25 00:22:35 UTC
Yep, we're aware of it since this afternoon. :) I'm just wondering how to fix it - for new enough GnuTLS we should either set the "NORMAL" priority string explicitly, or use gnutls_set_default_priority(), which currently has the same effect, but seems to be deprecated, and its default string might change in the future. I'm leaning towards the first option, more opinions are welcome.
Comment 2 Michael Rasmussen 2016-08-25 08:01:46 UTC
Just rebuild claws on latest Debian Unstable. No problems.

Which version of gnutls are we talking about?

$ dpkg -s gnutls-bin
Package: gnutls-bin
Status: install ok installed
Priority: optional
Section: net
Installed-Size: 925
Maintainer: Debian GnuTLS Maintainers <pkg-gnutls-maint@lists.alioth.debian.org>
Architecture: amd64
Multi-Arch: foreign
Source: gnutls28
Version: 3.5.3-3
Comment 3 users 2016-08-25 10:48:02 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2016-08-25 10:48:02.662783460 +0200
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=07303ccf22cb0f7ed10168f0b7d2a544490a4b1c
Merge: 8e82531 d6d4958
Author: Colin Leroy <colin@colino.net>
Date:   Thu Aug 25 10:48:02 2016 +0200

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=d6d495869a719e44a11785e38b8deed8ad09ab96
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Thu Aug 25 10:46:34 2016 +0200

    Always set GnuTLS priority string.
    
    Closes bug #3680.
Comment 4 Andrej Kacian 2016-08-25 10:48:57 UTC
GnuTLS version doesn't seem to matter, I can reproduce it also with 3.5.3 on *some* servers. I just pushed a commit that sets "NORMAL" priority string for GnuTLS >= 3.4.0.

Note You need to log in before you can comment on or make changes to this bug.