Bug 3527 - autoconfiguration: move button below server type
Summary: autoconfiguration: move button below server type
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: UI (show other bugs)
Version: 3.13.0
Hardware: All All
: P3 minor
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2015-09-28 12:43 UTC by Christian Hesse
Modified: 2015-09-29 21:51 UTC (History)
0 users

See Also:


Attachments
autoconfiguration: move button below server type (5.67 KB, patch)
2015-09-28 12:44 UTC, Christian Hesse
no flags Details | Diff
missing justification (53.69 KB, image/png)
2015-09-29 12:01 UTC, Ricardo Mones
no flags Details
autoconfiguration: move button below server type (5.62 KB, patch)
2015-09-29 12:21 UTC, Christian Hesse
no flags Details | Diff

Description Christian Hesse 2015-09-28 12:43:56 UTC
Autoconfiguration is protocol dependent, so let's choose server type
first, move the button below.
Comment 1 Christian Hesse 2015-09-28 12:44:13 UTC
Created attachment 1571 [details]
autoconfiguration: move button below server type
Comment 2 Ricardo Mones 2015-09-28 16:36:53 UTC
Wasn't this already posted somewhere?
Comment 3 Christian Hesse 2015-09-28 16:42:29 UTC
I posted this to the mailing list some time ago, but nobody cared. To make sure it does not get lost I opened a bug now.

If whoever grabs it from mailing list and commits it I will make sure to handle this bug and close it. ;)
Comment 4 Ricardo Mones 2015-09-29 12:01:52 UTC
Created attachment 1574 [details]
missing justification
Comment 5 Ricardo Mones 2015-09-29 12:02:29 UTC
(In reply to comment #3)
> I posted this to the mailing list some time ago, but nobody cared. To make
> sure it does not get lost I opened a bug now.
> 
> If whoever grabs it from mailing list and commits it I will make sure to
> handle this bug and close it. ;)

Allright. Anyway, for some reason the patch makes left-justification of the error label to be lost, see attached image (and I think is better to have it next to the button ;)
Comment 6 Christian Hesse 2015-09-29 12:21:28 UTC
Created attachment 1575 [details]
autoconfiguration: move button below server type

Updated patch fix fixes alignment.
Comment 7 users 2015-09-29 17:14:03 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2015-09-29 19:14:02.882047965 +0200
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=ed1b26c187b41d82241e59df0d714acdd79c1a31
Merge: 0d3c121 2c54352
Author: Colin Leroy <colin@colino.net>
Date:   Tue Sep 29 19:14:02 2015 +0200

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=2c54352ae2548b840d8fde00a05da062a70a9415
Author: Christian Hesse <mail@eworm.de>
Date:   Tue Sep 29 14:21:28 2015 +0200

    Fix bug #3527 ‘autoconfiguration: move button below server type’

Note You need to log in before you can comment on or make changes to this bug.