Bug 3507 - build fails w/o GnuTLS
Summary: build fails w/o GnuTLS
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Plugins/ManageSieve (show other bugs)
Version: 3.12.0
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2015-08-21 06:27 UTC by Andrew Warshall
Modified: 2015-08-21 18:56 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Andrew Warshall 2015-08-21 06:27:35 UTC 
When compiling on a machine without GnuTLS, compilation halts with:

managesieve.c: In function 'sieve_session_connect':
managesieve.c:843:9: error: 'SieveSession' has no member named 'tls_init_done'

and another similar one.

Looking in the source code, it appears the definition of tls_init_done in managesieve.h is conditioned by 

#ifdef USE_GNUTLS

but the reference(s) in managesieve.c are not similarly enclosed.

I don't know if it makes sense to make ManageSieve work w/o TLS, but if not then I think it should be disabled by ./configure on non-GnuTLS systems.
Comment 1 Charles E. Lehner 2015-08-21 18:55:28 UTC 
Thanks for the bug report. It should be fixed now in 2ff4e385f8ecdd417096aa859b87e252ab095cd7. The ManageSieve plugin may be useful without TLS if e.g. the server is on the local machine or accessed through a secure tunnel.
Note You need to log in before you can comment on or make changes to this bug.