Bug 3296 - improve description and labels
Summary: improve description and labels
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Plugins/Bogofilter (show other bugs)
Version: 3.10.1
Hardware: PC Linux
: P3 enhancement
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2014-10-13 10:49 UTC by progchild
Modified: 2015-09-24 09:44 UTC (History)
0 users

See Also:


Attachments

Description progchild 2014-10-13 10:49:41 UTC
If you uncheck the "Save spam in" check box in the configuration dialog. The messages are not left untouched and just marked as spam, but deleted. This is a very unexpected behavior. From the dialog it is not at all evident that mails are deleted.

I probably do not have to say that I lost a few important messages until I figured out what was happening. So I think the dialog should at least be changed, such that it is clear to the user that mails will be deleted. Otherwise this might happen to other people as well.
Comment 1 Paul 2014-10-13 10:58:05 UTC
They go to the Trash folder if you leave this option blank, as the tooltip says.
Comment 2 progchild 2014-10-13 18:36:25 UTC
I have checked all my computers. The messages are not in any of the trash folders.

From the bogofilter.c


/* flag spams and delete them if !config.receive_spam 
 * (if config.receive_spam is set, we'll move them later) */
for (cur = new_spams; cur; cur = cur->next) {
	MsgInfo *msginfo = (MsgInfo *)cur->data;
	if (config.receive_spam) {
		if (config.mark_as_read)
			procmsg_msginfo_unset_flags(msginfo, ~0, 0);
		procmsg_msginfo_set_flags(msginfo, MSG_SPAM, 0);
	} else {
		folder_item_remove_msg(msginfo->folder, msginfo->msgnum);
	}
}


The variable   config.receive_spam   is set corresponding to the value of the check box "Save spam in". I do not know what the function   folder_item_remove_msg   does exactly, but I would assume that it does not store the mails to the trash.
Comment 3 Paul 2014-10-13 18:38:22 UTC
In the plugin description, (when you loaded it), it says "When a message is identified as spam it can be deleted or saved in a specially designated folder."
Comment 4 progchild 2014-10-13 19:35:54 UTC
I am a little disapointed from this answer. It is true that one could interpret unchecking "Save Spam in" as "do not save the mail at all". And yes, the description gives more evidence to the actual behavior if you take into account that there is no "delete mail" check box. However, I did the mistake in thinking that unchecking means "do not touch this mail". And maybe some other people might do the same mistake as I did. Providing the option to delete mail is a very dangerous one. Thus I think that this option should be labeled /unambiguously/.

I am writing here to make a proposition for making your software better such that my mistake is not repeated by other people. However with that, I do not have the feeling to be taken seriously.
Comment 5 Paul 2014-10-13 19:40:05 UTC
fair enough.
Comment 6 progchild 2014-10-13 19:59:51 UTC
Thank you.

Note You need to log in before you can comment on or make changes to this bug.