Bug 3236 - sc_html_parse_tag() does not recognize '<br/>' as line break
Summary: sc_html_parse_tag() does not recognize '<br/>' as line break
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: UI/Message View (show other bugs)
Version: 3.10.1
Hardware: PC FreeBSD
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2014-07-30 12:24 UTC by Fabian Keil
Modified: 2014-07-30 14:00 UTC (History)
0 users

See Also:


Attachments
Fix bug 3236: "sc_html_parse_tag() does not recognize '<br/>' as line break" (771 bytes, patch)
2014-07-30 12:28 UTC, Fabian Keil
no flags Details | Diff

Description Fabian Keil 2014-07-30 12:24:44 UTC
sc_html_parse_tag() does not recognize '<br/>' as line break.

This can result in the HTML-encoded message losing more of
the intended formatting than necessary.

It's especially unpleasant if the HTML-encoded message is
an OpenPGP-encrypted message (pasted into a web-based MUA)
in which case the lost line breaks have to be added back
before the message can be decrypted.

I'll submit a patch once I have the bug id.
Comment 1 Fabian Keil 2014-07-30 12:28:39 UTC
Created attachment 1417 [details]
Fix bug 3236: "sc_html_parse_tag() does not recognize '<br/>'  as line break"
Comment 2 users 2014-07-30 13:59:02 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2014-07-30 13:59:02.016903227 +0200
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=77e5b54e83c532973fcf782440bf524d0f335053
Merge: 807f4be 6e2217d
Author: Colin Leroy <colin@colino.net>
Date:   Wed Jul 30 13:59:01 2014 +0200

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=6e2217d5bb5722a5426158f49bcaed95005a28f6
Author: Paul <paul@claws-mail.org>
Date:   Wed Jul 30 12:58:18 2014 +0100

    fix bug 3236, 'sc_html_parse_tag() does not recognize '<br/>' as line break'
    
    Patch by  Fabian Keil.
Comment 3 Paul 2014-07-30 14:00:41 UTC
thanks!!

Note You need to log in before you can comment on or make changes to this bug.