Bug 3211 - Fails to build in Debian hurd-i386 architecture
Summary: Fails to build in Debian hurd-i386 architecture
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Other (show other bugs)
Version: 3.11.0
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2014-06-13 09:43 UTC by Ricardo Mones
Modified: 2015-08-20 01:31 UTC (History)
0 users

See Also:


Attachments

Description Ricardo Mones 2014-06-13 09:43:33 UTC
Error is:

> libarchive_archive.c:313:22: error: 'PATH_MAX' undeclared (first use in this function)

Ideas for fixing: https://www.gnu.org/software/hurd/hurd/porting/guidelines.html
Although the usual fix is just #define it to some value at the appropriate level when not present. 

This is used also in mailmbox plugin, archiver is just the one that fails first :)
Comment 1 Colin Leroy 2014-06-13 09:47:31 UTC
Yeah, I'd guess just adding
#ifndef PATH_MAX
 #define PATH_MAX 4196
#endif

in utils.h should be enough :)
Comment 2 users 2014-06-17 11:00:03 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2014-06-17 11:00:02.910909608 +0200
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=1738a2aa659b644195b23be58dff8af22c15dfbb
Merge: ebd8958 822857b
Author: Colin Leroy <colin@colino.net>
Date:   Tue Jun 17 11:00:02 2014 +0200

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=822857b4d2c40faae26dc5444c5a5ecca1134c8e
Author: Ricardo Mones <ricardo@mones.org>
Date:   Mon Jun 16 21:40:57 2014 +0200

    Fix desktop file Categories and add Keywords

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=66d5513bcc307b46e81c2f11cbe8e3ebcd3d46a8
Author: Ricardo Mones <ricardo@mones.org>
Date:   Mon Jun 16 21:31:57 2014 +0200

    Fix bug #3211 “Fails to build in Debian hurd-i386 architecture”
Comment 3 Ricardo Mones 2014-10-21 13:34:12 UTC
The previous fix wasn't good enough and 3.11.0 fails again with:

,-------
| ...
| maillock.c: In function 'lock_common':
| maillock.c:143:21: error: 'PATH_MAX' undeclared (first use in this function)
|   char lockfilename[PATH_MAX];
| ...
`-------

Full log: https://buildd.debian.org/status/fetch.php?pkg=claws-mail&arch=hurd-i386&ver=3.11.0-1&stamp=1413878869

I guess a careful review of PATH_MAX references is required and utils.h should be included in the appropriate places.
Comment 4 users 2014-10-28 17:41:02 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2014-10-28 17:41:02.412960940 +0100
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=28bf51d652bfa804a622bb6792c356eae3751d6c
Merge: 39e416b 5800b5c
Author: Colin Leroy <colin@colino.net>
Date:   Tue Oct 28 17:41:02 2014 +0100

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=5800b5c77fd0bc8a26f1958635281c9fbd852e42
Author: Ricardo Mones <ricardo@mones.org>
Date:   Tue Oct 28 17:34:28 2014 +0100

    Fix bug #3211 ‘Fails to build in Debian hurd-i386’
Comment 5 Ricardo Mones 2015-08-20 01:31:14 UTC
Version 3.12.0-1 was build and installed in hurd-i386:
https://buildd.debian.org/status/package.php?p=claws-mail&suite=unstable

Note You need to log in before you can comment on or make changes to this bug.