Bug 3126 - libravatar: do not collect empty files
Summary: libravatar: do not collect empty files
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Plugins (show other bugs)
Version: 3.10.0
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2014-03-26 22:38 UTC by Christian Hesse
Modified: 2014-03-28 00:29 UTC (History)
0 users

See Also:


Attachments
do not collect empty files (864 bytes, application/x-download)
2014-03-26 22:38 UTC, Christian Hesse
mones: applied+
Details

Description Christian Hesse 2014-03-26 22:38:40 UTC
Created attachment 1358 [details]
do not collect empty files

Missing avatars are remembered in ~/.claws-mail/avatarcache/missing. So there is no need collecting empty files... Unlink avatar files if file size is zero.
Comment 1 Ricardo Mones 2014-03-27 08:36:03 UTC
Nice catch! and thanks for the patch :)
Comment 2 users 2014-04-08 15:29:04 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2014-04-08 15:29:04.273570764 +0200
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=b5860f91ffd836bdcd497d0fc26cf88ad6dbff98
Merge: f32f7d2 3a9aa84
Author: Colin Leroy <colin@colino.net>
Date:   Tue Apr 8 15:29:03 2014 +0200

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=3a9aa8405f460fba1d1d6be1a3aa2d6bba8537e6
Author: Ricardo Mones <ricardo@mones.org>
Date:   Sun Apr 6 02:24:39 2014 +0200

    Fix typo

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=ed20c6b9693e3f03e78dc996bf040bae226f121f
Author: Ricardo Mones <ricardo@mones.org>
Date:   Sat Apr 5 19:57:31 2014 +0200

    Update plugins section of manual
    
    • Merge extra plugins section, since they're all provided now.
    • Synchronize list of plugins with website list.
    • Add new “Obsolete plugins” section for the ones we're not
      shipping anymore for a variety of reasons.

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=0e9e5fa081832e34eb5eab806dc5cbb59dab67e0
Author: Ricardo Mones <ricardo@mones.org>
Date:   Sat Apr 5 18:41:05 2014 +0200

    Update source code references to add git and re-wrap

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=a697eae3b750b59e1c51cda98a91ef1360453f18
Author: Christian Hesse <mail@eworm.de>
Date:   Wed Mar 26 22:27:53 2014 +0100

    Fix bug #3126 “libravatar: do not collect empty files”
    
    Signed-off-by: Ricardo Mones <ricardo@mones.org>

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=73a8781b8463557a0ddabe7b1beb0507a4d2beca
Author: Paul <paul@claws-mail.org>
Date:   Thu Mar 27 16:16:32 2014 +0000

    when using Redirect, use the redirecting account's address in the SMTP MAIL FROM

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=d6156962e24689e1be484b8a44a4841719bf4679
Author: Colin Leroy <colin@colino.net>
Date:   Tue Mar 25 09:04:33 2014 +0100

    Fix bug #3120, "Error - file is empty" when redirecting a mail with
    an empty part: ask for confirmation when attaching an empty file,
    apart in batch mode where no confirmation is asked.

Note You need to log in before you can comment on or make changes to this bug.