Created attachment 1343 [details] libravatar: make mail address lower case before hashing MD5 The hash only matches if email address is lower case, so just do that.
Good catch Christian! And thanks for the patch, but since we're using glib I think using g_ascii_tolower instead of tolower would be better.
Makes sense... ;) Did not know about that function. Do you prepare that yourself or do you want a patch?
As you prefer: if you update the patch I'll commit as is, otherwise I'll do it myself tonight :)
Created attachment 1344 [details] libravatar: make mail address lower case before hashing MD5 Use g_ascii_tolower().
I'm very sorry and I should have thought twice before answering. Just realized that's not the correct point to convert the address to lowercase, because it will be done on every render, which is unnecessary and a waste of cpu cycles. Conversion to lowercase must be made on libravatar_header_update_hook, just after extract_address call, the address will be always in lowercase for any subsequent rendering calls.
Created attachment 1345 [details] libravatar: make mail address lower case before hashing MD5 Update patch, do conversion to lowercase on libravatar_header_update_hook(), just after extract_address() call.
Changes related to this bug have been committed. Please check latest Git and update the bug accordingly. You can also get the patch from: http://git.claws-mail.org/ ++ ChangeLog 2014-03-14 08:56:03.557538967 +0100 http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=719fc3f474022b0599b1dc636168bb6b64ddf7c8 Merge: 462d00f eeb18db Author: Colin Leroy <colin@colino.net> Date: Fri Mar 14 08:56:03 2014 +0100 Merge branch 'master' of file:///home/git/claws http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=eeb18db35ed1136568ae802b2fb7445315471025 Author: Christian Hesse <mail@eworm.de> Date: Thu Mar 13 15:03:39 2014 +0100 Fix bug #3109 “libravatar: make mail address lower case before hashing MD5” Thanks again Christian Hesse for the patch!