Bug 3019 - Messages with inline PGP signature not flagged as signed in the message list
Summary: Messages with inline PGP signature not flagged as signed in the message list
Status: RESOLVED WORKSFORME
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: UI/Message List (show other bugs)
Version: 3.9.2
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2013-10-20 00:41 UTC by Ian Nartowicz
Modified: 2013-10-20 21:22 UTC (History)
0 users

See Also:


Attachments
inline signed message lacking an indicator icon (216.11 KB, image/png)
2013-10-20 14:08 UTC, Ian Nartowicz
no flags Details

Description Ian Nartowicz 2013-10-20 00:41:24 UTC
Messages composed in Claws Mail and signed using the PGP/inline method can be received in Claws and the message is understood to have a good signature.  The mime type icon is marked with the signed/passed emblem and the signature details appear at the bottom of the message.

However, the message list attachment column does not indicate a signed message, either by icon or by tooltip.
Comment 1 Paul 2013-10-20 11:13:34 UTC
Works for me. Can you show  a screenshot, with the default internal theme?
Comment 2 Ian Nartowicz 2013-10-20 14:08:09 UTC
Created attachment 1305 [details]
inline signed message lacking an indicator icon
Comment 3 Ian Nartowicz 2013-10-20 14:11:08 UTC
I think this should show what is happening.  The preview pane shows that Claws Mail understands and accepts the inline signature.  The message list has no indication of the signature, but shows the signed icon for other messages with the signature in a MIME attachment.  I thought the message was from Claws but is apparently from Thunderbird.
Comment 4 Paul 2013-10-20 14:33:52 UTC
Please, if possible, forward-as-attachment, (privately), a message that demonstrates this behaviour.
Comment 5 Ian Nartowicz 2013-10-20 15:31:40 UTC
Forwarded ...

When I pressed the forward button, the correct icon appears in the paper-clip column!  It stays until I restart Claws, then it is gone again.
Comment 6 Paul 2013-10-20 15:47:04 UTC
Thanks for forwarding the example.
Your example works absolutely fine and as expected for me.
Comment 7 Ian Nartowicz 2013-10-20 16:19:31 UTC
I've sent some inline-signed messages to myself and they work fine.  I also forwarded the problem message, inline and as an attachment, and that works fine too.  So the original message is damaged in some way?  Or something in my settings when I received it?
Comment 8 Ian Nartowicz 2013-10-20 16:24:21 UTC
I did find another issue with inline-signed messages.  Perhaps should be a separate bug?  The signature should verify that the contents of the message are as they were when the message was signed, but if extra text is entered on the blank line between the HASH line and the rest of the message body then it is still declared to be validly signed.  Changes anywhere else in the message body result in a bad signature message.  The spec states that changes anywhere between the start of the HASH line, or the start of the PGP SIGNED line if there is no HASH line, and the signature should not be tolerated.
Comment 9 Paul 2013-10-20 18:03:26 UTC
(In reply to comment #8)
> if extra text is entered
> on the blank line between the HASH line and the rest of the message body
> then it is still declared to be validly signed.

Even gpg used directly will tell you that that's a good sig. It's only when you alter the text below that line that a bad sig is reported.
Comment 10 Paul 2013-10-20 18:15:08 UTC
Since this cannot be reproduced and everything works as expected, closing this as WORKSFORME.
Comment 11 Ian Nartowicz 2013-10-20 21:22:10 UTC
gpg standalone (1.4.12 from Debian Wheezy) returns status code 2 and a message that the armor header is invalid.  Return code 1 means bad signature, return code 2 means unexpected error.  gpgv does the same.  I don't know about the library API that I think Claws must use.

I've tried all sorts to reproduce the initial problem, but no joy.  It can't be a very common thing, although usually when I say that it turns out to be something painfully obvious.

Note You need to log in before you can comment on or make changes to this bug.