Bug 2912 - make git version consistent
Summary: make git version consistent
Status: RESOLVED INVALID
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Other (show other bugs)
Version: 3.9.1
Hardware: All All
: P3 trivial
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2013-04-26 10:44 UTC by Christian Hesse
Modified: 2013-04-29 10:33 UTC (History)
0 users

See Also:


Attachments
make git version consistent (363 bytes, application/octet-stream)
2013-04-26 10:44 UTC, Christian Hesse
no flags Details

Description Christian Hesse 2013-04-26 10:44:25 UTC
Created attachment 1259 [details]
make git version consistent

Default abbreviated commit hash has seven digids:

$ git log -1 --format="%h"               
be58b45
$ git describe
3.9.0-197-gbe58b45

But the string used in claws-mail has only six:

$ git describe --abbrev=6 --dirty --always
3.9.0-197-gbe58b4

I would like to make this consistent. Sounds crazy, but it took me some time to get the idea why package version and claws-mail version string did not match. :-p
Comment 1 Ricardo Mones 2013-04-26 11:19:43 UTC
To be honest don't understand much here, let me address some points:

* Version _is_ consistent with what git says, just shorter.

* Which package version string are you talking about? 

* And why have we to match with that package version and not the other way round?
Comment 2 Christian Hesse 2013-04-26 12:07:17 UTC
Technically the version string used at the moment is just fine, and it is consistent in terms of uniqueness.

It is not consistent in terms of the default format used by git for short commit hashes, though.

When building binary packages for my system I do use 'git describe' to generate the version string. It's the default with git itself, so I will not change it the other way round.

As said, technically it is just fine as is, I just want to match default git behavior.
Comment 3 Ricardo Mones 2013-04-29 10:33:36 UTC
That response doesn't answer my question and, as of course, it's not a valid reason to change the generated version number.

Note You need to log in before you can comment on or make changes to this bug.