Bug 2878 - bsfilter / folder.c:1435 Condition identifier != NULL failed
Summary: bsfilter / folder.c:1435 Condition identifier != NULL failed
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Plugins/BSfilter (show other bugs)
Version: 3.9.0
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2013-02-14 23:04 UTC by Michael Schwendt
Modified: 2013-11-08 13:45 UTC (History)
0 users

See Also:


Attachments

Description Michael Schwendt 2013-02-14 23:04:19 UTC
bsfilter 1.0.9

Claws Mail 3.9.0 logs a traceback when I select a message in a local mbox (or also IMAP) folder and choose "Learn as Spam":

$ claws-mail 
folder.c:1435 Condition identifier != NULL failed
traceback:
0:	claws-mail(folder_find_item_from_identifier+0x172) [0x488d22]
1:	/usr/lib64/claws-mail/plugins/bsfilter.so(bsfilter_get_spam_folder+0x15) [0x7f964118c3a5]
2:	claws-mail(procmsg_spam_get_folder+0x12) [0x53f8e2]
3:	claws-mail(summary_mark_as_spam+0x1cf) [0x55ceff]
4:	claws-mail() [0x56abba]
5:	/lib64/libgobject-2.0.so.0(g_closure_invoke+0x138) [0x344880fb28]
6:	/lib64/libgobject-2.0.so.0() [0x344882140d]
7:	/lib64/libgobject-2.0.so.0(g_signal_emit_valist+0xd6f) [0x344882959f]
8:	/lib64/libgobject-2.0.so.0(g_signal_emit+0x82) [0x34488297c2]
9:	/lib64/libgtk-x11-2.0.so.0(gtk_widget_activate+0x7c) [0x7f964b22fa1c]
10:	/lib64/libgtk-x11-2.0.so.0(gtk_menu_shell_activate_item+0xfd) [0x7f964b11e17d]
11:	/lib64/libgtk-x11-2.0.so.0(+0x15652c) [0x7f964b11e52c]
12:	/lib64/libgtk-x11-2.0.so.0(+0x1413fc) [0x7f964b1093fc]
13:	/lib64/libgobject-2.0.so.0(g_closure_invoke+0x138) [0x344880fb28]
14:	/lib64/libgobject-2.0.so.0() [0x34488211af]
15:	/lib64/libgobject-2.0.so.0(g_signal_emit_valist+0x4c4) [0x3448828cf4]
16:	/lib64/libgobject-2.0.so.0(g_signal_emit+0x82) [0x34488297c2]
17:	/lib64/libgtk-x11-2.0.so.0(+0x268d54) [0x7f964b230d54]
18:	/lib64/libgtk-x11-2.0.so.0(gtk_propagate_event+0xc4) [0x7f964b107644]
19:	/lib64/libgtk-x11-2.0.so.0(gtk_main_do_event+0x2eb) [0x7f964b107a0b]
20:	/lib64/libgdk-x11-2.0.so.0(+0x5eaac) [0x7f964ad66aac]
21:	/lib64/libglib-2.0.so.0(g_main_context_dispatch+0x146) [0x3448447e76]
22:	/lib64/libglib-2.0.so.0() [0x34484481c8]
23:	/lib64/libglib-2.0.so.0(g_main_loop_run+0x6a) [0x34484485ca]
24:	/lib64/libgtk-x11-2.0.so.0(gtk_main+0xa7) [0x7f964b106ac7]
25:	claws-mail(main+0x114a) [0x447eba]
26:	/lib64/libc.so.6(__libc_start_main+0xf5) [0x3445c21b75]
27:	claws-mail() [0x4493a1]
Comment 1 Michael Schwendt 2013-02-14 23:08:31 UTC
It seems this is because in the bsfilter preferences one can mark the "Save spam in" checkbox without choosing a target folder. The bsfilter plugin then causes  the traceback, but moves the spam message to the Trash folder.
Comment 2 users 2013-04-19 00:21:10 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=1a980a6ed69e4c979dd268c5d3a875548289e587
Author: Ricardo Mones <ricardo@mones.org>
Date:   Fri Apr 19 00:17:16 2013 +0200

    Fix bug #2878 'bsfilter / folder.c:1435 Condition identifier != NULL failed'
    
    Don't call folder_find_item_from_identifier if using default
    NULL value

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=c282d90e6d5a2764dcfe1c2c88c83ecee2cabd86
Author: Ricardo Mones <ricardo@mones.org>
Date:   Fri Apr 19 00:14:25 2013 +0200

    Update year in manual copyright notices
Comment 3 Ricardo Mones 2013-11-08 13:45:07 UTC
In 3.9.2 release.

Note You need to log in before you can comment on or make changes to this bug.