Bug 2641 - 7bit or 8bit encoded attachments can have lines longer than 998 characters
Summary: 7bit or 8bit encoded attachments can have lines longer than 998 characters
Status: RESOLVED INVALID
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: SMTP (show other bugs)
Version: 3.9.0
Hardware: PC All
: P3 minor
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2012-04-03 12:44 UTC by madroach+claws
Modified: 2013-11-03 10:43 UTC (History)
0 users

See Also:


Attachments
break lines longer than 998 characters (1.63 KB, patch)
2012-04-03 12:51 UTC, madroach+claws
no flags Details | Diff
fix bugs 2638-2642 (15.76 KB, patch)
2012-08-29 22:00 UTC, madroach+claws
no flags Details | Diff

Description madroach+claws 2012-04-03 12:44:55 UTC
a patch is attachet. Still, no warning will be displayed when lines are broken.
Comment 1 madroach+claws 2012-04-03 12:51:52 UTC
Created attachment 1101 [details]
break lines longer than 998 characters
Comment 2 users 2012-07-03 23:34:33 UTC
Changes related to this bug have been committed.
Please check latest CVS and update the bug accordingly.
You can also get the patch from:
http://www.claws-mail.org/tracker/

2012-07-03 [mir]	3.8.1cvs4

	* src/procmime.c
	* src/common/defs.h
            fix bug 2641, '7bit or 8bit encoded attachments can
            have lines longer than 998 characters'.
            Patch provided by Christopher Zimmermann
            (madroach claws at gmerlin dot de)


2012-07-03 [mir]	3.8.1cvs3

	* src/procmime.c
	* src/common/defs.h
	    fix bug 2641, '7bit or 8bit encoded attachments can
	    have lines longer than 998 characters'.
	    Patch provided by Christopher Zimmermann
	    (madroach claws at gmerlin dot de)
Comment 3 users 2012-07-03 23:34:34 UTC
Changes related to this bug have been committed.
Please check latest CVS and update the bug accordingly.
You can also get the patch from:
http://www.claws-mail.org/tracker/

2012-07-03 [mir]	3.8.1cvs4

	* src/procmime.c
	* src/common/defs.h
            fix bug 2641, '7bit or 8bit encoded attachments can
            have lines longer than 998 characters'.
            Patch provided by Christopher Zimmermann
            (madroach claws at gmerlin dot de)


2012-07-03 [mir]	3.8.1cvs3

	* src/procmime.c
	* src/common/defs.h
	    fix bug 2641, '7bit or 8bit encoded attachments can
	    have lines longer than 998 characters'.
	    Patch provided by Christopher Zimmermann
	    (madroach claws at gmerlin dot de)
Comment 4 Paul 2012-07-10 23:19:01 UTC
I reverted this patch and the patches attached to bugs #2640 and #2642 as (somewhere) they cause partial message text loss. This was reproducible pasting in long lines using /Edit/Special paste/Unwrapped. Reverted the lot as it's a serious bug and it's the quickest way to make sure cvs is safe again.
Comment 5 madroach+claws 2012-07-14 12:30:26 UTC
Hi,
I built latest cvs patched and unpatched. In both cases I
CANNOT reproduce partial message loss. Only when autowrapping is turned
on I get additional newlines inserted. This seems to be the expected
behavior and is NOT dependent on my patchset.
Can you confirm that you are able to reproduce partial message loss? Maybe you can track down where the message loss occurs by looking at your local folders where the queued message is stored and see whether that is intact.
Comment 6 Colin Leroy 2012-08-29 16:10:12 UTC
Hi 

At the time, most of the team has been able to reproduce using this:

From: Paul <claws@thewildbeast.co.uk>
To: devel@lists.claws-mail.org
Subject: [Devel] 3.8.1cvs13/14
Date: Tue, 10 Jul 2012 22:49:57 +0100
3.8.1cvs13/14 : fix message text loss bug

I was pasting in a track list and noticed the garbled output (after
sending!).

To see this bug in action before you upgrade, trying pasting the
following text in the compose window using
/Edit/Special Paste/Unwrapped

You'll notice some text is lost completely and other lines are
joined 'oddly':

manmachineman - Chess - [the rhytmdesign rising 1997]
Bezun
Comment 7 madroach+claws 2012-08-29 22:00:57 UTC
Created attachment 1152 [details]
fix bugs 2638-2642

I still cannot reproduce this bug. I guess some of the patches I uploaded are broken or a part is missing. So here's a newly generated diff against latest cvs tested with the example mail content (tracklist).
Comment 8 Paul 2013-11-03 10:42:38 UTC
this rewrite failed and is, apparently, abandoned.

Note You need to log in before you can comment on or make changes to this bug.