Bug 2577 - Focus rectangle on folder list and message list headings doesn't get properly cleared when switching heading and horizontally scrolling list (underlines and vertical lines remain on screen)
Summary: Focus rectangle on folder list and message list headings doesn't get properly...
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: UI (show other bugs)
Version: 3.8.0
Hardware: PC Linux
: P3 minor
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2012-01-05 20:45 UTC by pezcurrel
Modified: 2014-11-10 14:24 UTC (History)
0 users

See Also:


Attachments
Message and folder headings showing a black line at their bottom (79.42 KB, image/png)
2012-01-05 20:45 UTC, pezcurrel
no flags Details
Too many vertical lines :) (57.04 KB, image/png)
2012-01-09 10:52 UTC, pezcurrel
no flags Details
Lines and underlines beneath entries in the folder pane and message header pane. (188.21 KB, image/png)
2012-01-09 14:36 UTC, Little Girl
no flags Details
Subject tip breaks the focuse rectangle line (223.74 KB, image/png)
2012-01-09 15:05 UTC, pezcurrel
no flags Details

Description pezcurrel 2012-01-05 20:45:18 UTC
Created attachment 1060 [details]
Message and folder headings showing a black line at their bottom

Since upgrading to 3.8.0 on Ubuntu 10.04, if I click on a message heading in the message list, and then click on another, the previously selected message heading often shows a black line (sometimes "broken") at its bottom.
Same goes with the folder list.
(See the image attachment)
This bug shows even on a different account on the same machine, on a fresh claws setup.
Comment 1 Little Girl 2012-01-07 07:18:19 UTC
I can confirm the same symptoms in Claws Mail 3.8.0 in Kubuntu 10.04, although the lines aren't always black since they can be affected by header coloring, which I'm very fond of adding. (:
Comment 2 Paul 2012-01-07 09:41:46 UTC
It's not directly related to using (K)ubuntu 10.04 - I use the same with no such effects - it's almost certainly related to your GTK+ theme
Comment 3 Little Girl 2012-01-07 19:58:17 UTC
I would think so if the behavior was consistent, but this behaves like a memory leak or some other bug. If I have multiple folders in the folder pane or multiple message headers in the message pane:

- I can click them one by one from top to bottom, and sometimes I cause the line and sometimes I don't. The same is true if I click them one by one from bottom to top or even if I click them randomly.

- If I then click any of them again, sometimes clicking on one that doesn't have a line gets one, and other times it doesn't, and clicking on one that has a line sometimes removes it and other times it doesn't.

- Some of the lines are full length across the entire width of the folder pane or message header pane, underlining all available columns, and some of the lines are partial, covering only part of the message subject or any other part of the line, for instance, while leaving the rest of that line alone.

I wouldn't be surprised to find out that pezcurrel sees exactly the same thing. Note, also, that this can be easily repeated. I could show it to you in under ten seconds at any time, which means I can rely upon it to misbehave. (:
Comment 4 pezcurrel 2012-01-08 12:08:04 UTC
> It's not directly related to using (K)ubuntu 10.04 - I use the same with no
> such effects - it's almost certainly related to your GTK+ theme

I tried (always on a fresh user account and fresh claws setup) with different, "official" (not modified) themes, and also on a plain X session, with same results. I also tried with different X drivers (nvidia, nouveau, fbdev, vesa), with same results, and always nothing relevant in ~/.xsession-errors, /var/log/Xorg.0.log, /var/log/syslog

> I wouldn't be surprised to find out that pezcurrel sees exactly the same thing.

I do... Maybe it's somehow platform-related... I am using a macbook 5,2 booting with grub-efi; what platform are you using?
Comment 5 Andreas Rönnquist 2012-01-08 12:12:47 UTC
I can confirm this on a Debian stable, with the following data:

- GTK+ 2.20.1 / GLib 2.24.2
- Lokal: sv_SE.UTF-8 (teckenkodning: UTF-8)
- Operativsystem: Linux 2.6.32-5-amd64 (x86_64)
- Nvidia 7950 graphicscard, Nvidia long-lived branch release 275,43
- Xfce 4.6.2
Comment 6 Ricardo Mones 2012-01-08 15:10:21 UTC
It's not reproducible here, neither 3.7.6 (OS packaged) nor latest CVS build, so I agree with Paul this is very likely a GTK+ theme issue.

OS: Debian stable (Squeeze) + few backports
Kernel: Linux 2.6.39-bpo.2-amd64
Video: Intel Corporation Mobile 945GM/GMS, 943/940GML Express Integrated Graphics Controller
GTK/GLib: 2.20.1-2/2.24.2-1
GNOME Desktop with Awesome WM and Debian default GTK+ theme
Comment 7 Kevin Nathan 2012-01-08 18:14:10 UTC
I cannot reproduce it here, either. It really does sound like a GTK theme issue.

System Information
GTK+ 2.22.1 / GLib 2.28.0
Locale: en_US.UTF-8 (charset: UTF-8)
Operating System: Linux 2.6.37.6-0.9-desktop (i686)

openSUSE 11.4 (i586)
using WindowMaker as primary desktop; also tried it on KDE4, icewm, fvwm, LXDE, XFCE and twm...
Comment 8 pezcurrel 2012-01-08 20:51:51 UTC
I don't understand how it could be a gtk+ theme issue, since it shows with any gtk theme I'm using. I'm not polemic, just want to understand :)

> It's not reproducible here, neither 3.7.6 (OS packaged) nor latest CVS build

3.7.6 worked correctly here too, the bug shows on 3.8.0-1ubuntu0~ppalucid0ubuntu1
I also tried cvs build with same results (also compiled with "CFLAGS=-O1", just to try...).

My setup...

Macbook 5.2
OS: Ubuntu 10.04
Kernel: Linux 2.6.32-37-generic x86_64
Video: nVidia Corporation C79 [GeForce 9400M G] (rev b1)
Processor: Intel Core2 Duo P7350 @ 2.00GHz
GTK: 2.20.1-0ubuntu2.1
GLib: 2.24.1-0ubuntu1
Gnome 2.30.0-0ubuntu1 (tried also with xfce and "xterm session", same results)
Comment 9 pezcurrel 2012-01-08 21:06:19 UTC
I've forgotten to mention that if I minimize and then maximize claws' window, the black lines go away and the screen shows correctly; if I drag another window above claws' one, any black lines' pixel under the window I'm dragging gets cleared.
Comment 10 Little Girl 2012-01-09 04:53:41 UTC
My hardware:
- Graphics card: NVIDIA GeForce 8600GT video card
- Hard drive: Western Digital SATA
- Motherboard: ASUS M2N-E AM2
- Processor: AMD Athlon 2.4 Ghz dual core
- RAM - Corsair DDR2 SDRAM 2 GB 

My software:
- Email: Claws Mail 3.8.0
- Operating system: Kubuntu 10.04 LTS (Lucid Lynx)
- Desktop: KDE 4.4.5
- Boot manager: GRUB 1.98
- Dependency for Claws Mail: GTK version? No idea. Maybe you can tell me which version I have. This is what dpkg -l | grep libgtk has to say:
ii  libgtk2.0-0                          2.20.1-0ubuntu2.1                               The GTK+ graphical user interface library
ii  libgtk2.0-bin                        2.20.1-0ubuntu2.1                               The programs for the GTK+ graphical user int
ii  libgtk2.0-common                     2.20.1-0ubuntu2.1                               Common files for the GTK+ graphical user int
ii  libgtkmm-2.4-1c2a                    1:2.20.3-0ubuntu1                               C++ wrappers for GTK+ (shared libraries)
ii  libgtksourceview2.0-0                2.10.4-0ubuntu1                                 shared libraries for the GTK+ syntax highlig
ii  libgtksourceview2.0-common           2.10.4-0ubuntu1                                 common files for the GTK+ syntax highlightin
ii  libgtkspell0                         2.0.16-1                                        a spell-checking addon for GTK's TextView wi
Comment 11 Little Girl 2012-01-09 05:07:37 UTC
Just like pezcurrel, if I cover the Claws Mail window with another program or minimize and maximize it, the lines go away.

I've done some more experimenting and here are some more diagnostics that can be relied upon to be consistent and repeatable:

- Clicking on an entry in the folder pane that has a folder with no messages in it will never underline it.

- Clicking on an entry in the folder pane that has a folder with at least one message in it can and will sometimes underline it.

- Clicking on an entry in the folder pane that has a folder with at least one message in it and is underlined can and will sometimes remove the underline with no discernible pattern to the behavior.

- Clicking on an entry in the folder pane that has a folder with at least one message in it will never underline it if you first click on an entry in the folder pane that has a folder with no messages in it.

- Clicking on an entry in the folder pane that has a folder with at least one message in it will never underline it if you click on it and then click on an entry in the folder pane that has a folder with no messages in it.

- Clicking on an entry in the folder pane that has a folder with no messages in it will clear all underlines in the folder pane and in the message header pane.

- Clicking on a message header in the message header pane can and will sometimes be underlined with no discernible pattern to the behavior.

- Clicking on a message header in the message header pane that has a full or partial underline can and will sometimes remove the underline with no discernible pattern to the behavior.
Comment 12 Little Girl 2012-01-09 05:13:26 UTC
Sorry for the multiple posts here, but I forgot to mention that this trouble began when I upgraded to Claws Mail 3.8.0 and wasn't present in any previous version of Claws I've used over the years.

Also, the underlines don't interfere with the use of the program. Copying, moving, receiving mail, sending mail, filtering, moving messages to trash, etc., all work fine.

And last, but not least, the name of this bug should probably be changed since the lines are only black if you don't use custom colors. (:
Comment 13 Paul 2012-01-09 07:22:08 UTC
That's a lot of information, but nowhere do you state which GTK theme/theme engine you are using
Comment 14 Roman Brusa 2012-01-09 09:18:54 UTC
I'd like to add a voice to confirm this, as described by pezcurrel and Little Girl. My setup:

Ubuntu 10.04.3 LTS (Lucid)
GTK+: 2.20.1-0ubuntu2.1
GLib: 2.24.1-0ubuntu1
Kernel: 2.6.32-37-386
Xfce 4.6.1
GTK+-2.0 theme engine for Xfce: 2.6.0-2
Comment 15 pezcurrel 2012-01-09 10:52:39 UTC
Created attachment 1062 [details]
Too many vertical lines :)
Comment 16 pezcurrel 2012-01-09 11:01:43 UTC
I have the bug with any theme I try, for example "clearlooks" and "human".
"clearlooks engine" comes with "gtk2-engines 1:2.20.0-0ubuntu1" (/usr/lib/gtk-2.0/2.10.0/engines/libclearlooks.so), "human" uses - guessing from dependencies - "gtk2-engines-murrine 0.90.3+git20100323-0ubuntu3" (/usr/lib/gtk-2.0/2.10.0/engines/libmurrine.so).
Also tried with "gtk2-engines-xfce 2.6.0-2".

I tried to mess with the cvs code and found out that I can "fix" the problem by changing src/gtk/gtkcmctree.c, line 941 ("/* draw focus rectangle */" block), from..
cairo_rectangle(cr, row_rectangle.x, row_rectangle.y,
..to..
cairo_rectangle(cr, row_rectangle.x, row_rectangle.y - 1,

It works here, but I really wouldn't call it a fix since I just "tried something", basing a guess on the behaviour on my setup, and didn't even try to understand all the logic behind the involved code since I guess it would take much time for me.. hope this can be of some help for developers.

Another "brute fix" is to comment out the..
//	    cairo_stroke(cr);
..few lines below, which completely disables the drawing of the focus rectangle (here focus can be seen anyway by the different background color of selected heading, as it was in previous versions).

Also, there's another strange behaviour: when scrolling the message headings list from right to left, vertical lines stay drawed on the selected heading.. see the attachment in previous comment (this doesn't get "fixed" by the first change I wrote of).
Comment 17 Little Girl 2012-01-09 14:35:17 UTC
> That's a lot of information, but nowhere do you state which GTK theme/theme
engine you are using

If this was directed at me, I'm not using GTK. It's only there as a dependency of Claws Mail. I use KDE (with its Oxygen theme. So whatever theme GTK would install and make available for use by default if it was pulled in as a dependency would be the one that's being used, and that information should be available from the Kubuntu package repository. (:

Also, looking at the picture that pezcurrel just uploaded, that is not at all what I'm seeing. I'm attaching a picture of what I see, and note in that picture that some of the underlines do not go all the way across, but are broken.
Comment 18 pezcurrel 2012-01-09 14:36:06 UTC
Errata corrige :)

> Another "brute fix" is to comment out the..
> //        cairo_stroke(cr);
> ..few lines below...

Another "brute fix" is to comment out the..
        cairo_stroke(cr);
..few lines below...
Comment 19 Little Girl 2012-01-09 14:36:51 UTC
Created attachment 1063 [details]
Lines and underlines beneath entries in the folder pane and message header pane.

Note that some of the lines are broken.
Comment 20 pezcurrel 2012-01-09 15:04:22 UTC
> Also, looking at the picture that pezcurrel just uploaded, that is not at all
> what I'm seeing.

No, but it's related.
I guess if you add some colums to your message list pane, and try to scroll it horizontally left to right and then back, you will also see the vertical lines.

> I'm attaching a picture of what I see, and note in that
> picture that some of the underlines do not go all the way across, but are
> broken.

On my setup, the lines get broken after the subject tooltip for the selected heading pops up before the focus rectangle and then disappear.. see the attachment in (probably) next comment :)
Comment 21 pezcurrel 2012-01-09 15:05:51 UTC
Created attachment 1064 [details]
Subject tip breaks the focuse rectangle line
Comment 22 Little Girl 2012-01-09 15:50:09 UTC
Yep, it was the vertical lines that threw me. I don't have those, but everything else is the same, so we are having the same issue. (:

I notice the selected heading has a broken line under it in your latest uploaded image. My selected headings also sometimes have a broken line.

Good catch on the tooltip causing the line to be broken. I can cause a break anywhere on a line if I open a tooltip on it by hovering the mouse over a message above it, and that's consistent behavior.
Comment 23 pezcurrel 2012-01-10 19:44:20 UTC
I have the same problem on my desktop pc[*] with a fresh and "all default" ubuntu 10.04.3 install, with any gtk theme I try. No problems instead on the same machine with ubuntu 11.10, unity and gnome 3 (gtk 3).
Seems to me that by now what the setups "suffering" from the bug have all in common is the combination of gtk 2.20.1, glib 2.24.x and an nvidia graphics card (although I have the same bug using fbdev, nouveau and vesa xorg drivers).
For Ricardo Mones: do you have an nvidia gc too?

[*]
OS: Ubuntu 10.04.3
Kernel: Linux 2.6.32-37-generic x86_64
GTK: 2.20.1-0ubuntu2.1
GLib: 2.24.1-0ubuntu1
Gnome 2.30.0-0ubuntu1
Video: nvidia g86 [geforce 8500 gt] (rev a1)
Comment 24 Michael Rasmussen 2012-01-10 21:35:19 UTC
I can confirm this too.

But it does not seem to related to using Nvidia since my Ubuntu 10.04 is running in VirtualBox and the host system have this graphics card:

Intel(R) GMA X4500 Video Device

To narrow things down I installed a vanilla Debian Stable:
System Information
GTK+ 2.20.1 / GLib 2.24.2
Locale: en_US.utf8 (charset: UTF-8)
Operating System: Linux 2.6.32-5-amd64 (x86_64)
Identical to Ubuntu 10.04.

And build claws-mail-3.8.0.

The results was the same as with Ubuntu - black lines below text. Using the vertical ruler will redraw the lines correct.
Comment 25 Paul 2012-01-11 07:32:32 UTC
I tested the various themes listed above, no problems with any. Each of you with the problem is listing GTK+ 2.20.1 / GLib 2.24.2. I guess you are also all using libcairo 1.8.10.

Here I've got
GTK+ 2.24.6
GLib 2.30.0
Cairo 1.10.2
and everything is sweet.
Comment 26 Ricardo Mones 2012-01-11 08:34:38 UTC
What Paul says matches here: I'm using a backported libcairo2  (1.10.2-6~bpo60) on my stable systems (because of using a backported iceweasel) and dont' see the problem.
Comment 27 pezcurrel 2012-01-11 18:33:50 UTC
For Michael Rasmussen:

> Using the vertical ruler will redraw the lines correct.

What's the vertical ruler, how can one activate it?

Anyway, could it be a reasonable solution to make the cairo focus rectangle drawing active by default but disableable even with just a clawsrc option, and make a new build for ubuntu ppa?
As I wrote before, here (and maybe on most or all setups?) focus can be seen even without the focus rectangle, by the different background color of selected heading(s), as it was in previous versions.
Comment 28 Michael Rasmussen 2012-01-11 23:48:11 UTC
I just did a backport of cairo-1.10.2-6.2 to Debian squeeze which also includes installing the backports of libpixman-1-0.24.

Rebuild claws against cairo-1.10.2-6.2 did not solve the problem. So Mones, you must have something else changed/backported as well.
Comment 29 Michael Rasmussen 2012-01-12 00:48:03 UTC
I was jumping to conclusions, a reboot after the backport of cairo-1.10.2-6.2 did the trick:-)

QeD. cairo-1.8.10 contains a bug! However, fixing this seems to be a dead end.
Comment 30 Little Girl 2012-01-12 02:58:14 UTC
I don't think it's libcairo 1.8.10 because I don't have that installed:

$ locate 1.8.10

$ dpkg -s cairo
Package `cairo' is not installed and no info is available.
Use dpkg --info (= dpkg-deb --info) to examine archive files,
and dpkg --contents (= dpkg-deb --contents) to list their contents.

$ dpkg -s libcairo
Package `libcairo' is not installed and no info is available.
Use dpkg --info (= dpkg-deb --info) to examine archive files,
and dpkg --contents (= dpkg-deb --contents) to list their contents.

$ locate cairo
/usr/lib/libcairo.so.2
/usr/lib/libcairo.so.2.10800.10
/usr/lib/libcairomm-1.0.so.1
/usr/lib/libcairomm-1.0.so.1.4.0
/usr/lib/libpangocairo-1.0.so.0
/usr/lib/libpangocairo-1.0.so.0.2800.0
/usr/lib/openoffice/basis3.2/program/cairocanvas.uno.so
/usr/lib/pymodules/python2.6/cairo
/usr/lib/pymodules/python2.6/cairo/__init__.py
/usr/lib/pymodules/python2.6/cairo/__init__.pyc
/usr/lib/pymodules/python2.6/cairo/_cairo.so
/usr/lib/pymodules/python2.6/gtk-2.0/pangocairo.so
/usr/lib/pyshared/python2.6/cairo
/usr/lib/pyshared/python2.6/cairo/_cairo.so
/usr/lib/pyshared/python2.6/gtk-2.0/pangocairo.so
/usr/share/app-install/desktop/cairo-clock.desktop
/usr/share/app-install/desktop/cairo-dock.desktop
/usr/share/app-install/icons/cairo-clock.png
/usr/share/doc/libcairo2
/usr/share/doc/libcairomm-1.0-1
/usr/share/doc/python-cairo
/usr/share/doc/libcairo2/AUTHORS.gz
/usr/share/doc/libcairo2/NEWS.gz
/usr/share/doc/libcairo2/README.gz
/usr/share/doc/libcairo2/changelog.Debian.gz
/usr/share/doc/libcairo2/changelog.gz
/usr/share/doc/libcairo2/copyright
/usr/share/doc/libcairomm-1.0-1/AUTHORS
/usr/share/doc/libcairomm-1.0-1/NEWS.gz
/usr/share/doc/libcairomm-1.0-1/README
/usr/share/doc/libcairomm-1.0-1/changelog.Debian.gz
/usr/share/doc/libcairomm-1.0-1/copyright
/usr/share/doc/python-cairo/AUTHORS
/usr/share/doc/python-cairo/NEWS.gz
/usr/share/doc/python-cairo/README
/usr/share/doc/python-cairo/changelog.Debian.gz
/usr/share/doc/python-cairo/copyright
/usr/share/doc/python-cairo/examples
/usr/share/doc/python-cairo/examples/gradient.py
/usr/share/doc/python-cairo/examples/hering.py
/usr/share/doc/python-cairo/examples/spiral.py
/usr/share/doc/python-cairo/examples/warpedtext.py
/usr/share/pyshared/cairo
/usr/share/pyshared/cairo/__init__.py
/usr/share/python-support/python-cairo.public
/var/lib/dpkg/info/libcairo2.list
/var/lib/dpkg/info/libcairo2.md5sums
/var/lib/dpkg/info/libcairo2.postinst
/var/lib/dpkg/info/libcairo2.postrm
/var/lib/dpkg/info/libcairo2.shlibs
/var/lib/dpkg/info/libcairo2.symbols
/var/lib/dpkg/info/libcairomm-1.0-1.list
/var/lib/dpkg/info/libcairomm-1.0-1.md5sums
/var/lib/dpkg/info/libcairomm-1.0-1.postinst
/var/lib/dpkg/info/libcairomm-1.0-1.postrm
/var/lib/dpkg/info/libcairomm-1.0-1.shlibs
/var/lib/dpkg/info/python-cairo.list
/var/lib/dpkg/info/python-cairo.md5sums
/var/lib/dpkg/info/python-cairo.postinst
/var/lib/dpkg/info/python-cairo.preinst
/var/lib/dpkg/info/python-cairo.prerm
Comment 31 Little Girl 2012-01-12 04:04:37 UTC
I spoke too soon. I do have it:

libcairo2 version 1.8.10-2ubuntu1
Comment 32 users 2012-02-29 16:49:34 UTC
Changes related to this bug have been committed.
Please check latest CVS and update the bug accordingly.
You can also get the patch from:
http://www.claws-mail.org/tracker/

2012-02-29 [colin]	3.8.0cvs30

	* src/gtk/gtkcmctree.c
		Fix bug #2577, "Focus rectangle on folder list and message 
		list headings doesn't get properly cleared when switching 
		heading and horizontally scrolling list (underlines and 
		vertical lines remain on screen)". Patch by Michael Shell
Comment 33 Andreas Rönnquist 2014-11-07 19:45:35 UTC
There's still one place where this needs to be fixed:

diff --git a/src/gtk/gtkcmclist.c b/src/gtk/gtkcmclist.c
index b280758..68b2acc 100644
--- a/src/gtk/gtkcmclist.c
+++ b/src/gtk/gtkcmclist.c
@@ -6610,9 +6610,9 @@ gtk_cmclist_draw_focus (GtkWidget *widget)
     cairo_dash_from_add_mode(clist, cr);
     cairo_set_line_width(cr, 1.0);
     cairo_set_antialias(cr, CAIRO_ANTIALIAS_NONE);
-    cairo_rectangle(cr, 0, ROW_TOP_YPIXEL(clist, clist->focus_row),
+    cairo_rectangle(cr, 0, ROW_TOP_YPIXEL(clist, clist->focus_row) + 0.5,
            clist->clist_window_width + 1,
-           clist->row_height);
+           clist->row_height - 0.5);
     cairo_stroke(cr);
     cairo_destroy(cr);
   }
Comment 34 Andreas Rönnquist 2014-11-07 19:54:17 UTC
Gah, that previous patch was obviously incomplete, there's a similar unfocus function just below the focus one:

diff --git a/src/gtk/gtkcmclist.c b/src/gtk/gtkcmclist.c
index b280758..737b278 100644
--- a/src/gtk/gtkcmclist.c
+++ b/src/gtk/gtkcmclist.c
@@ -6610,9 +6610,9 @@ gtk_cmclist_draw_focus (GtkWidget *widget)
     cairo_dash_from_add_mode(clist, cr);
     cairo_set_line_width(cr, 1.0);
     cairo_set_antialias(cr, CAIRO_ANTIALIAS_NONE);
-    cairo_rectangle(cr, 0, ROW_TOP_YPIXEL(clist, clist->focus_row),
+    cairo_rectangle(cr, 0, ROW_TOP_YPIXEL(clist, clist->focus_row) + 0.5,
 			clist->clist_window_width + 1,
-			clist->row_height);
+			clist->row_height - 0.5);
     cairo_stroke(cr);
     cairo_destroy(cr);
   }
@@ -6639,9 +6639,9 @@ gtk_cmclist_undraw_focus (GtkWidget *widget)
     cairo_set_line_width(cr, 1.0);
     gdk_cairo_set_source_color(cr, &gtk_widget_get_style(widget)->base[GTK_STATE_NORMAL]);
     cairo_set_antialias(cr, CAIRO_ANTIALIAS_NONE);
-    cairo_rectangle(cr, 0, ROW_TOP_YPIXEL(clist, clist->focus_row),
+    cairo_rectangle(cr, 0, ROW_TOP_YPIXEL(clist, clist->focus_row) + 0.5,
 			clist->clist_window_width + 1,
-			clist->row_height);
+			clist->row_height - 0.5);
     cairo_stroke(cr);
     cairo_destroy(cr);
   }
Comment 35 Andreas Rönnquist 2014-11-10 14:24:21 UTC
An image of the effects of that latest patch above, before and after:

http://www.gusnan.se/images/claws-mail-patch-difference.png

To reproduce the problem, Shift Down and Shift Up right after in the message list, without releasing the shift key. (The problem might not be visible on all GTK themes, I don't really know).
Comment 36 users 2014-11-24 00:47:02 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2014-11-24 01:47:02.371150154 +0100
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=e1db9b774a56dd6d96b4b7c269cc8640f297c433
Merge: 9641bff a10cf75
Author: Colin Leroy <colin@colino.net>
Date:   Mon Nov 24 01:47:01 2014 +0100

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=a10cf7518f9d97e9925a9807dd9f3da283225776
Author: Ricardo Mones <ricardo@mones.org>
Date:   Mon Nov 24 01:43:10 2014 +0100

    Bug #2577 → improve focus rectangle removal in summaryview
    
    Patch by Andreas Rönnquist, thanks!

Note You need to log in before you can comment on or make changes to this bug.