Bug 2390 - Non-fully-trusted-key-warning appears based on primary UID rather than recipient e-mail
Summary: Non-fully-trusted-key-warning appears based on primary UID rather than recipi...
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Plugins/Privacy/PGP (show other bugs)
Version: 3.7.8
Hardware: PC Linux
: P3 critical
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2011-03-28 09:27 UTC by Christopher Head
Modified: 2012-10-10 09:49 UTC (History)
0 users

See Also:


Attachments

Description Christopher Head 2011-03-28 09:27:56 UTC
If a GPG key's primary user ID is not fully trusted, the function "use_untrusted()" in "src/plugins/pgpcore/select-keys.c" runs and shows a message warning of the untrusted key.

Trust is based on the presence or absence of signatures, and each signature is attached to a user ID, not to the key as a whole. Therefore, each user ID can have a different level of validity within the same key. Therefore, Claws ought to check the validity of the user ID corresponding to the e-mail address to which the message is being sent, NOT the primary user ID of the key. By signing a user ID, I assert not only that the key belongs to the person whose name appears in the UID, I also assert that the e-mail address on the UID belongs to the person. If I have made this assertion for some e-mail addresses and not others, those addresses for which I have made the assertion should not provoke a warning.

Even worse, if I have asserted the primary UID's e-mail address, I would *not* get a warning when sending mail to a secondary address which I've never checked! This means that if Alice phones up Mallory and verifies her key fingerprint and that her e-mail address is mallory@example.com, then signs her key, all Mallory has to do is add bob@example.com as a secondary UID to her key and wait for Alice to refresh her keys from the keyserver. When Alice sends Bob a message, if she's forgotten to first download Bob's key, she will unwittingly encrypt it to Mallory. Claws will show no warning message, even though Alice never signed Mallory's bob@example.com UID!
Comment 1 users 2012-09-05 13:39:35 UTC
Changes related to this bug have been committed.
Please check latest CVS and update the bug accordingly.
You can also get the patch from:
http://www.claws-mail.org/tracker/

2012-09-05 [colin]	3.8.1cvs43

	* src/plugins/pgpcore/select-keys.c
		Fix bug #2390, "Non-fully-trusted-key-warning appears
		based on primary UID rather than recipient e-mail"

Note You need to log in before you can comment on or make changes to this bug.