Bug 2321 - Add icon GTK_STOCK_CLEAR to the theme
Summary: Add icon GTK_STOCK_CLEAR to the theme
Status: NEW
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: UI/Compose Window (show other bugs)
Version: 3.7.8
Hardware: PC Linux
: P3 enhancement
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2010-12-04 09:37 UTC by Johan Spee
Modified: 2010-12-06 18:50 UTC (History)
0 users

See Also:


Attachments

Description Johan Spee 2010-12-04 09:37:23 UTC
file: compose.c
line: 6513

/* Entry field with cleanup button */
button = gtk_button_new();
gtk_button_set_image(GTK_BUTTON(button), gtk_image_new_from_stock(GTK_STOCK_CLEAR,
GTK_ICON_SIZE_MENU));
gtk_widget_show(button);

Could this icon be included in the theme please? It is just about the only one that is not already in there.

Thanks,

Johan
Comment 1 Johan Spee 2010-12-04 22:36:32 UTC
I just had another look...

There are 24 instances of "gtk_image_new_from_stock" in the source
code. This is rather inconsistent and perhaps an argument to allow all
icons to be taken from stock (as an option).
Comment 2 Paul 2010-12-04 22:53:30 UTC
That couldn't even be an option because the stock icons don't offer all the necessary icons.
Comment 3 Johan Spee 2010-12-05 09:16:31 UTC
Evolution uses stock icons (only),as does KMail- so it should not be to difficult. Maybe some creative choices would have to be made to suit Claws-mail specific needs, but still... If you are willing to add the option I am willing to see if I can match all theme icons with counterparts from stock - you could make a final decision on the basis of that.

Anyway, the stock icon in the compose window really sticks out (the others, I think, are all in dialogs). So I'd be happy if this one could be added to the Claws theme.

Cheers.
Comment 4 Paul 2010-12-06 18:13:04 UTC
By 'stock icons' we mean GTK+ stock icons: http://library.gnome.org/devel/gtk/stable/gtk-Stock-Items.html

Therefore evolution does not use only stock icons, and kmail is not even a GTK+ app so uses none.
Comment 5 Johan Spee 2010-12-06 18:50:53 UTC
I'll take that as a No.

How about the original request? 
The stock icon in the compose window - could that be added to the theme?

Note You need to log in before you can comment on or make changes to this bug.