Bug 1984 - Claws Mail does not support the anwser prefix used by French Lotus Notes
: Claws Mail does not support the anwser prefix used by French Lotus Notes
Status: CLOSED FIXED
: Claws Mail
Other
: 3.7.3
: PC Linux
: P3 normal
Assigned To:
:
:
:
  Show dependency treegraph
 
Reported: 2009-08-16 15:47 by
Modified: 2009-08-21 21:41 (History)


Attachments
Add support for French Lotus Notes 'Réf. :' prefix for email subjects (1.81 KB, patch)
2009-08-16 15:47, Didier Barvaux
no flags Details | Diff
Add support for French Lotus Notes 'Réf. :' prefix for email subjects (with WIN32 part) (2.12 KB, patch)
2009-08-21 14:56, Didier Barvaux
no flags Details | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-08-16 15:47:25
Created an attachment (id=715) [details]
Add support for French Lotus Notes 'Réf. :' prefix for email subjects

French Lotus Notes prefixes the email subject with 'Réf. :'. This a French
translation for 'Re:'. Claws Mail does not support such prefix yet. So the
email subject quickly becomes: 'Re: Réf. : Re: Réf. : Re: Réf. :'. This makes
emails threads between Claws Mail and French Lotus Notes quite difficult to
read.

The attached patch add support for the 'Réf. :' prefix for email subjects. The
patch also moves the description of the subject_get_prefix_length() function
closer to the definition of function.

The patch was tested against an email sent by a French Lotus Notes. The test
email is unfortunately private and cannot be attached to this bug for others to
test the patch.
------- Comment #1 From 2009-08-17 08:45:11 -------
Thanks for the patch; it's uncomplete, though: this function has two
implementations, one regexp-based for POSIX, one string-match based for Windows
(due to regexp problems on Windows). That's why the function header was higher
in the code.
------- Comment #2 From 2009-08-17 10:38:15 -------
OK. I will update that part too.
------- Comment #3 From 2009-08-21 14:56:28 -------
Created an attachment (id=719) [details]
Add support for French Lotus Notes 'Réf. :' prefix for email subjects (with
WIN32 part)

Patch updated to add WIN32 support. The WIN32 part was not tested on Windows
but tested on Linux thanks to a temporary change of the "#ifndef G_OS_WIN32"
test.

The header describing the subject_get_prefix_length() function is still moved
closer to the function definition.
------- Comment #4 From 2009-08-21 15:34:27 -------
I forgot to say that the last version of the patch is against Claws Mail
3.7.2cvs20.
------- Comment #5 From 2009-08-21 18:00:05 -------
Applied, thanks ! (3.7.2cvs21)
------- Comment #6 From 2009-08-21 18:00:39 -------
Changes related to this bug have been committed.
Please check latest CVS and update the bug accordingly.
You can also get the patch from:
http://www.colino.net/claws-mail/

2009-08-21 [colin]    3.7.2cvs22

    * src/compose.c
    * src/prefs_common.c
    * src/prefs_common.h
    * src/prefs_compose_writing.c
    * src/common/utils.c
        Fix bug 1986, "New feature: warn user when inserting 
        a large file in the message body". Patch by Didier
        Barvaux

        Fix bug 1984: Add Réf. : reply prefix (french 
        Lotus Notes); patch by Didier Barvaux
------- Comment #7 From 2009-08-21 21:40:02 -------
I checked with version 3.7.2cvs24 and it worked fine. Thank you.
------- Comment #8 From 2009-08-21 21:41:04 -------
Everything is fine, close the bug.
------- Comment #9 From 2009-10-12 22:00:34 -------
Changes related to this bug have been committed.
Please check latest CVS and update the bug accordingly.
You can also get the patch from:
http://www.colino.net/claws-mail/

2009-10-09 [paul[    3.7.3

    version 3.7.3 unleashed!!

        Fix bug 1984: Add R�f. : reply prefix (french