Bug 1951 - C-Mail dumps core when editing displayed headers
Summary: C-Mail dumps core when editing displayed headers
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Other (show other bugs)
Version: 3.7.1
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2009-07-09 21:50 UTC by Alexey Rusakov
Modified: 2009-07-12 11:15 UTC (History)
0 users

See Also:


Attachments
Fixes the crash after displayed headers editing (52 bytes, text/plain)
2009-07-09 21:50 UTC, Alexey Rusakov
no flags Details

Description Alexey Rusakov 2009-07-09 21:50:30 UTC
Created attachment 695 [details]
Fixes the crash after displayed headers editing

Steps to reproduce:
1. Configuration -> Preferences... -> Message View -> Text Options.
2. Press 'Edit...'
3. Drag 'From' somewhere, drop.
4. Drag 'From' back to the place it was on.
5. Press 'Cancel'
There's some problem with the row_changed signal - in some situations iterating through the tree model returns the same pointer more than once, that leads to double-free when closing the window. Looks as if there's an intermediate state during row_changed signal: the dragged element exists in both old and new places.
The proposed patch moves the code from row_changed handler to drag_end(). With this patch, Claws Mail no more crashes in the given case.
Comment 1 users 2009-07-10 09:43:38 UTC
Changes related to this bug have been committed.
Please check latest CVS and update the bug accordingly.
You can also get the patch from:
http://www.colino.net/claws-mail/

2009-07-10 [colin]	3.7.2cvs6

	* src/prefs_display_header.c
		Fix bug 1951, 'C-Mail dumps core when editing 
		displayed headers'. Patch by Alexey Rusakov
Comment 2 Alexey Rusakov 2009-07-12 11:15:29 UTC
Thank you.

Note You need to log in before you can comment on or make changes to this bug.