Bug 1489 - Filter action mark_as_read inoperative following move action
Summary: Filter action mark_as_read inoperative following move action
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Filtering (show other bugs)
Version: 3.2.0
Hardware: All Linux
: P3 enhancement
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2008-01-24 18:08 UTC by Walt Bilofsky
Modified: 2011-11-21 09:18 UTC (History)
0 users

See Also:


Attachments

Description Walt Bilofsky 2008-01-24 18:08:26 UTC
If a filter action has a move to folder, followed by a mark_as_read, the mark_as_read doesn't happen.

I am informed that all the actions following a move are similarly inoperative.  See discussion under Bug 1488: http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=1488 )

Recommendation:  The action constructing process should always put the move action last.

Justification:  Users should not be expected to know this.
Comment 1 Paul 2008-01-24 18:35:06 UTC
Users should also read the manual.
Comment 2 Walt Bilofsky 2008-01-25 18:05:19 UTC
(In reply to comment #1)
> Users should also read the manual.
> 
The manual refers to a different behavior: "... if Claws Mail finds a rule suitable for an email that either moves or deletes the email, it will stop looking for further rules for that email."  That refers to looking for further rules.  This bug concerns the actions within a single rule.

The rule says 

"move "#mh/Mail/Walt's Email/Junk mark_as_read"

This rule does not do what it says.  That is a bug.

I suggest that even if the manual were changed to document failing to execute some actions within a rule, this would be unexpected program behavior.  There is a slick UI that lets the user construct this rule, and the user has a right to expect it to do what it says.

There are plenty of ways to fix this.  Here are three, in increasing order of both quality and effort:

1) Rename the "move" rule to "move and terminate actions". 
2) Force the "move" action to the end of the action list. 
3) Fix the code so the action list isn't terminated by "move".

I appreciate the work that everyone puts in on this great program, and am only trying to help polish it further.  Apologies in advance if I am violating etiquette on this, but I will reopen this as a bug.
Comment 3 Gerard Seibert 2008-01-25 19:40:21 UTC
I had a similar situation where certain rules were failing and I was not immedaitely able to ascertain why. I have since discovered that it is because the 'move' action was not the last action in a statement.

I agree that the wording for 'move' should be changed to indicate this action. I would tend to think that having the program automatically reformat the statement so that 'move' is moved to the end of the statement might at some point introduce problems. Eliminating the need for 'move' to be the last action in a statement would seem like the obvious solution however.
Comment 4 Holger Berndt 2008-01-25 21:42:17 UTC
It's not only 'move'. It's at least also the 'delete' and 'stop' actions that are final.
Comment 5 Paul 2008-01-26 09:38:22 UTC
change 'hardware', it's not maemo-specific
Comment 6 Andy 2011-09-29 15:16:17 UTC
I created the following AutoIT script which is launched from a AutoHotkey keyboard shortcut to get round this issue:

; AutoIT script to move a message to the actioned folder.
; A bug in the move action command (where it jumps to the top of the inbox) means I have to use this.
WinActivate("Claws Mail")
; Ctrl-M is the keyboard shortcut assigned to Move to folder
send("^M")
; A selects the folder I want to move to (mine is called ActionedItems
send("A{ESC}")
send("!o")
Comment 7 Andy 2011-09-29 15:25:21 UTC
Sorry added above comment to the wrong Bug reference - please ignore.
Comment 8 users 2011-11-20 22:08:34 UTC
Changes related to this bug have been committed.
Please check latest CVS and update the bug accordingly.
You can also get the patch from:
http://www.colino.net/claws-mail/

2011-11-20 [pawel]	3.7.10cvs96

	* src/filtering.c
	* src/filtering.h
	* src/prefs_actions.c
		Fix bug #1489 'Filter action mark_as_read inoperative
		following move action'
		Sort actions lists to have proper order of execution

Note You need to log in before you can comment on or make changes to this bug.