Bug 4130

Summary:

Please reconsider merging the patch syntax highlight

Product:

Claws Mail (GTK 2)

Reporter:

Jakub Kiciński <kubakici>

Component:

UI/Message View

Assignee:

users

Status:

RESOLVED FIXED

Severity:

enhancement

Priority:

Version:

other

Hardware:

OS:

Linux

Attachments:

Description	Flags
small fix for diff detection from git	none
the actual feature	none

Description Jakub Kiciński 2018-12-01 22:03:07 UTC

Three years back I submitted a patch to highlight git --diff syntax in-line inside email bodies.  It was rejected due to fear of false positives.

I've used it since and never had a false positive.  I have also found that other people have very similar patches on GitHub, which makes me thinks its a popular feature.

I have had a quite a few of my coworkers start using my fork of Claws just to get the patch coloring, and subsequently go back to Thunderbird because of the extra hassle of having to compile from source and rebase.  I think it would be a really good thing for the project if the feature got merged.

Patches are available here:
https://github.com/kuba-moo/claws-mail/commit/ed5adc67276e7ee0e50c031daccfddcc92488e30
https://github.com/kuba-moo/claws-mail/commit/36300a476c2dc401dd78e3396a6b19848041c08f

Please let me know if I can improve them somehow.

Comment 1 Paul 2018-12-01 22:57:38 UTC

Can you attach the patches here, please?

Comment 2 Jakub Kiciński 2018-12-02 01:59:42 UTC

Created attachment 1939 [details]
small fix for diff detection from git

Comment 3 Jakub Kiciński 2018-12-02 02:00:22 UTC

Created attachment 1940 [details]
the actual feature

Comment 4 wwp 2018-12-02 10:17:42 UTC

Interesting, I'm currently running CM w/ this patch applied, will see if I get false positives or negatives.
BTW, some changes in 3.16.0-191-g0c28ce4 may indicate that it would be better to match all known signatures instead of checking for "-- \n" only.

Comment 5 Olivier Brunel 2018-12-02 13:30:11 UTC

For what it's worth, I've been running claws with those patches for years now without (noticing) any issues. Great addition IMO.

Also for reference, original bug is:
https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=3035

Comment 6 Paul 2018-12-02 13:35:57 UTC

*** Bug 3035 has been marked as a duplicate of this bug. ***

Comment 7 wwp 2019-09-27 12:21:49 UTC

Both patches pushed to git (3.17.4-32-gd7d8bd63d), with minor adaptations so that all known signature separators are taken into account (the standard one and the custom ones defined in local accounts in prefs).
Thanks for contributing!