| Summary: | Strings around MAILIMAP_ERROR could use some whitespace fixes | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Claws Mail (GTK 2) | Reporter: | Andreas Rönnquist <andreas> | ||||||||
| Component: | UI/Translations | Assignee: | users | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | enhancement | ||||||||||
| Priority: | P3 | ||||||||||
| Version: | 3.13.1 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 1616 [details]
imap.c Diff
Created attachment 1617 [details]
Better version of the patch
Patch adding the space but not making it part of the translatable strings.
(In reply to comment #2) > Created attachment 1617 [details] > Better version of the patch > > Patch adding the space but not making it part of the translatable strings. Now that you're at it: why is ' ' different from '\n' or vice versa? :-) Created attachment 1622 [details]
Remove endofline from translatable strings too
Alright, another version attached. Changes related to this bug have been committed. Please check latest Git and update the bug accordingly. You can also get the patch from: http://git.claws-mail.org/ ++ ChangeLog 2016-02-19 19:05:03.091026802 +0100 http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=934a788a3fa80bc958c9d555d93f376860ee55f5 Merge: bfc970d bb97461 Author: Colin Leroy <colin@colino.net> Date: Fri Feb 19 19:05:02 2016 +0100 Merge branch 'master' of file:///home/git/claws http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=bb974610e7ce07776f00c3eaa6743a6d458ee94d Author: Ricardo Mones <ricardo@mones.org> Date: Fri Feb 19 19:03:15 2016 +0100 Fix bug #3578: Strings around MAILIMAP_ERROR… …could use some whitespace fixes. Patch by Andreas Rönnquist (thanks!). |
The switch-case in src/imap.c contains lots of translatable strings, each case contains _("IMAP error on %s:") and then the error messages starting the string with a space, like _(" connection refused\n") Why not put that space into the end of the "IMAP error on %s: " string, instead of on each error message string. This would make it one place where one can miss the space, instead of lots and lots.