Summary: | Template addressing | ||||||
---|---|---|---|---|---|---|---|
Product: | Claws Mail (GTK 2) | Reporter: | MD <crxssi> | ||||
Component: | Other | Assignee: | users | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | enhancement | ||||||
Priority: | P3 | ||||||
Version: | 3.13.0 | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
MD
2015-12-01 15:06:59 UTC
Created attachment 1703 [details]
Possible fix
This patch fixes this issue for me, which hit me this morning when trying to modify a template :)
Checks are removed from all address fields, since they're parsed later when template is applied. This allows both for local addresses and complex addresses, always using commas for separation and optionally any number of spaces for readability.
I understand initial intention of this code was to provide a pre-validated input before inserting, but the implemented checks are too simplistic and restrict usage causing more problems than benefits: some invalid addresses are still allowed and some valid addresses are not allowed at all, so twice bad ;-)
So far so good, no regression w/ the patch applied here against latest git version. Even tried few naive tests and no problem. Not a guarantee anyway! Changes related to this bug have been committed. Please check latest Git and update the bug accordingly. You can also get the patch from: http://git.claws-mail.org/ ++ ChangeLog 2016-12-10 13:34:03.135481008 +0100 http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=57207707795a3a26a23f260782055398e51c01cf Merge: a6ee4c0 9123296 Author: Colin Leroy <colin@colino.net> Date: Sat Dec 10 13:34:02 2016 +0100 Merge branch 'master' of file:///home/git/claws http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=9123296406a1f61f21464ca8fd439d315b4c8367 Author: Ricardo Mones <ricardo@mones.org> Date: Sat Dec 10 13:32:41 2016 +0100 Fix bug #3574: Template addressing Remove artificial limitations to values of email addresses on templates: these strings are already parsed and split when the template is applied in compose window. |