Bug 3353

Summary:

unify date/time stamping of all console/log messages

Product:

Claws Mail (GTK 2)

Reporter:

Pierre Fortin <pf>

Component:

Other

Assignee:

users

Status:

NEW ---

Severity:

enhancement

Priority:

Version:

3.12.0

Hardware:

OS:

Linux

Attachments:

Description	Flags
timestamp debug messages	none

Description Pierre Fortin 2014-12-18 14:43:41 UTC

I see a lot of konsole messages and log messages with missing timestamps (date or date&time) which makes it difficult to associate these messages with what's going on.

Please unify all konsole/log output so that all messages are date/time stamped.

Providing settings to enable/disable date and/or time stamps would be OK, though I would choose to display date/time everywhere for the above reason.

Comment 1 Ricardo Mones 2016-05-04 18:42:08 UTC

Created attachment 1644 [details]
timestamp debug messages

Not sure if this is all what you wanted in this request, but it's a start ;-)

Comment 2 Pierre Fortin 2016-05-05 10:09:45 UTC

(In reply to comment #1)

> Not sure if this is all what you wanted in this request, but it's a start ;-)

Thanks for the 'start' :) -- really appreciated!
Compiled latest git + these mods; but not yet seeing what I was hoping for...
Digging into the code (I can read it somewhat; but haven't written C in over 40 years), it appears the code I'm hoping to see get time stamps is in src/common/log.h where there are refs to G_GNUC_PRINTF (also in src/common/utils.h, src/privacy.h, and possibly src/alertpanel.h & src/statusbar.h)  Found https://developer.gnome.org/glib/stable/glib-Miscellaneous-Macros.html#G-GNUC-PRINTF:CAPS but I don't yet see how to change 
  void log_* (LogInstance instance, const gchar *format, ...) G_GNUC_PRINTF(2, 3);
to add time stamps...  Guessing change to struct _LogText needed; but... :)

Comment 3 Ricardo Mones 2016-05-05 13:40:05 UTC

I see, you were probably referring to messages in internal log than in console.

This patch only timestamps --debug log (the "console" part) to help debugging. 

Anyway, this is not going to be pushed, so consider yourself at the starting point again ;-)