| Summary: | Contact merging | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Claws Mail (GTK 2) | Reporter: | Charles E. Lehner <cel> | ||||||||
| Component: | UI/Address Book | Assignee: | users | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | enhancement | ||||||||||
| Priority: | P3 | ||||||||||
| Version: | 3.12.0 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| Attachments: |
|
||||||||||
Seems a good idea but is unfortunate that it discards information. Created attachment 1456 [details]
[patch] Add contact merging, with user prompt
I've updated the patch now to prompt the user for which picture to keep, and which name to keep, in the cases where contacts with multiple pictures or different names are selected for merging.
Feedback is welcome!
Anyone have thoughts on this? I still think it's a useful feature to add. Sounds promising, I'll give it a try and review the patch. Created attachment 1863 [details]
Patch updated to build against recent GIT and GTK (+fixes)
Sorry for the delay.. I had to update the patch so that it builds against fresh GIT code, and solve use of deprecated GTK+ calls, but also fixing the picture selection (previous patch was getting picture data that could not be used to check picture filenames). Basically the patch works, as far as I could test it. There are ways to enhance it, like making the dialog contents expanding upon dialog resize, sorting names, adding a tooltip or another side-widget that would show full contact detail upon picture or name selection, and maybe in-depth contact data checking because currently it only checks for name data to determine if contacts are similar (IIRC). Updated patch builds and works nicely here, I'd say push it! ;-) Changes related to this bug have been committed. Please check latest Git and update the bug accordingly. You can also get the patch from: http://git.claws-mail.org/ ++ ChangeLog 2018-04-10 00:26:07.515195760 +0200 http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=d705f90f18bbdb91babd1ac9e83cad06c919f6ec Merge: ef5e4d1 f25722a Author: Colin Leroy <colin@colino.net> Date: Tue Apr 10 00:26:05 2018 +0200 Merge branch 'master' of file:///home/git/claws http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=f25722af77b9378ce0fcfb4c3d09b9bd3c01902a Author: wwp <wwp@free.fr> Date: Tue Apr 10 00:23:14 2018 +0200 Add a basic contact merging feature to the address book, thanks to Charles Lehner <cel@celehner.com>. Closes bug 3346: Contact merging |
Created attachment 1454 [details] [patch] Add contact merging feature in address book This patch adds a simple contact merging operation, to help users with merging contacts by hand in the address book. With multiple contacts selected, "Merge" can be chosen from the pop-up menu or Edit menu. Then the selected emails or persons will be combined into one entry with their attributes combined. Currently the names and photos of persons other than the first selected person are lost in the merge, as only the emails and attributes are moved. More logic could be added to allow the user to choose which name and photo to keep for the contact.