Bug 3320

Summary: claws-mail.desktop missing
Product: Claws Mail (GTK 2) Reporter: Chris <chrisretusn>
Component: OtherAssignee: users
Status: RESOLVED FIXED    
Severity: normal    
Priority: P3    
Version: 3.11.1   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch for Makefie.in none

Description Chris 2014-11-01 11:27:01 UTC
Created attachment 1446 [details]
Patch for Makefie.in

I use Slackware with KDE.

After successfully compiling from source and installing. Then tried to start Claws Mail from my Quicklaunch icon it failed, missing "claws-mail.desktop". The menu option was also missing. 

Perhaps this was intentional, perhaps not. Noted in change log "Remove appdata." Is claws-mail.desktop part of "appdata"? I'm thinking it's not, of course I could be wrong. The file is present in the root tree of the source. 

At any rate I created a patch for Makefile.am and Makefile.in correct this possible oversight. Seems to work alright. My Quicklaunch icon works as expected and the menu item is back. 

=== Patch for Makefile.am ====
--- Makefile.am	2014-10-28 02:56:56.000000000 +0800
+++ Makefile.am.new	2014-11-01 16:41:05.534958325 +0800
@@ -34,6 +34,11 @@
 pixmap128dir=$(datadir)/icons/hicolor/128x128/apps
 pixmap128_DATA=claws-mail-128x128.png
 
+# when changing the name or location of the .desktop file,
+# also update src/common/Makefile.am
+gnomapdir = $(datadir)/applications
+gnomap_DATA=claws-mail.desktop
+
 rename-icons:
 	@cd $(DESTDIR)$(datadir)/icons/hicolor/64x64/apps && \
             mv claws-mail-64x64.png claws-mail.png
====

Patch for Makefile.in attached.
Comment 1 Christian Hesse 2014-11-01 11:35:45 UTC
This is already fixes in git.