| Summary: | Avatar plugin priority | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Claws Mail (GTK 2) | Reporter: | Christian Hesse <mail> | ||||
| Component: | Plugins | Assignee: | users | ||||
| Status: | NEW --- | ||||||
| Severity: | enhancement | ||||||
| Priority: | P3 | ||||||
| Version: | 3.10.0 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Christian Hesse
2014-04-28 13:54:20 UTC
Trying to get this in place... Any hints how to manage this at runtime and where/how to save the configuration? Created attachment 1411 [details]
prepare GUI for avatar priority
Just started by writing some GUI code... The important things are still missing, though.
Don't take it bad but my initial idea for this is not to have it centralized at all. The core should not care about this priority since it's an arrangement among plugins of some kind. I don't like the idea of having code in core for this even if no avatar plugin is loaded, only the strictly required (which ideally should be nothing :) One idea for this is applying something similar to what is done with pgp plugins: one avatarcore plugin with the common code (something similar to the priority management you depicted in your patch) and the other avatar-related plugins would reuse it. Also some common interface would have to be defined: at least functions to query/set priority all avatar-related plugins should implement, so the avatarcore would invoke them for each of them appropriately. Maybe also some user-friendly identification function to help GUI. Had not much time to think about the details, but more or less that's the big picture right now. So if you want to invest time on this I think that's the way to go, more than adding more code to the core. Thanks in advance! (In reply to comment #3) > Don't take it bad but my initial idea for this is not to have it centralized > at all. The core should not care about this priority since it's an > arrangement among plugins of some kind. I don't like the idea of having code > in core for this even if no avatar plugin is loaded, only the strictly > required (which ideally should be nothing :) Agreed, I am with you. ;) > One idea for this is applying something similar to what is done with pgp > plugins: one avatarcore plugin with the common code (something similar to > the priority management you depicted in your patch) and the other > avatar-related plugins would reuse it. Ok, but this requires X-/Face support got to a plugin as well, no? > Also some common interface would have to be defined: at least functions to > query/set priority all avatar-related plugins should implement, so the > avatarcore would invoke them for each of them appropriately. Maybe also > some user-friendly identification function to help GUI. > > Had not much time to think about the details, but more or less that's the > big picture right now. So if you want to invest time on this I think that's > the way to go, more than adding more code to the core. I will think about it. All of this sound reasonable so far I think. > Thanks in advance! |