Bug 2903

Summary:	key 'C' mention harcoded in string
Product:	Claws Mail (GTK 2)	Reporter:	Ricardo Mones <mones>
Component:	UI/Message View	Assignee:	users
Status:	RESOLVED FIXED
Severity:	minor
Priority:	P3
Version:	3.9.1
Hardware:	PC
OS:	Linux

Description Ricardo Mones 2013-04-06 02:32:57 UTC

On signed messages the signature check row appears below the message with a lock icon and a label that reads "The signature has not been checked. Click the icon or hit 'C' to check it."

If the user has set a different preset keyboard shortcuts, or simply remapped the menu entry accelerator, the 'C' is not available for signature checking.

The easy fix would be to remove the mention of the 'C' key and simply refer to the menu option "Message/Check signature".

Showing also the current value of the menu accelerator of that option (if any) would be an even better fix, of course.

Comment 1 users 2013-04-10 22:41:04 UTC

Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=cb4a06aafd414b25b88d74f9a659dd397a28e3f0
Author: Colin Leroy <colin@colino.net>
Date:   Wed Apr 10 22:40:07 2013 +0200

    Fib bug #2903, "key 'C' mention harcoded in string"

Comment 2 Ricardo Mones 2013-04-20 12:20:43 UTC

Thanks Colin for the patch!

Nevertheless there's still some rough edges:

- If there's no key assigned it reads "or hit the '' key", I guess in those cases would be better to remove that and leave the "Click the icon" text only.

- If the checking timeouts, the string is still harcoded and reads "Timeout checking the signature. Click the icon or hit 'C' to try again." :)

Comment 3 Paul 2013-04-23 14:30:42 UTC

now fixed (again!) in GIT