| Summary: | Incorrect undo/redo operations after paste with replace from context menu | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Claws Mail (GTK 2) | Reporter: | Mikhail Efremov <mikhefr> | ||||
| Component: | UI/Compose Window | Assignee: | users | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | normal | ||||||
| Priority: | P3 | ||||||
| Version: | 3.7.6 | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
Changes related to this bug have been committed. Please check latest Git and update the bug accordingly. You can also get the patch from: http://git.claws-mail.org/ ++ ChangeLog 2014-05-22 21:12:03.387256711 +0200 http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=1218f02ac0c175bf1a28c515f1e6aa4b69a9e36c Merge: 67bb273 61e19ee Author: Colin Leroy <colin@colino.net> Date: Thu May 22 21:12:02 2014 +0200 Merge branch 'master' of file:///home/git/claws http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=61e19ee9a509f9c4535a0dfb21a08faffb05f079 Author: Colin Leroy <colin@colino.net> Date: Thu May 22 21:10:13 2014 +0200 Fix bug #2238, "Incorrect undo/redo operations after paste with replace from context menu". Order of insert/delete is reversed when pasting from the context menu. Patch by Mikhail Efremov. Hi Mikhail, Sorry for lagging 4 years on a bugreport with a patch! Thanks, applied :) |
Created attachment 877 [details] claws-mail-3.7.6-fix-undo-redo-replace.patch Steps to reproduce: 1. Edit a new message, then select some word and replace it from context menu (right mouse button). 2. Press Ctrl+Z, then press Ctrl+Y, the result will be incorrect and backtrace will generate. Patch is attached. I do not quite understand the case with the middle button in undo_redo(), so I just assume that next action in the list can be not only UNDO_ACTION_REPLACE_DELETE.