Summary: | No automatic NNTP filtering | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Claws Mail (GTK 2) | Reporter: | rgaddi | ||||||
Component: | Filtering | Assignee: | users | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | normal | CC: | boxcars, flobber | ||||||
Priority: | P3 | ||||||||
Version: | 3.10.0 | ||||||||
Hardware: | PC | ||||||||
OS: | Windows XP | ||||||||
Attachments: |
|
Description
rgaddi
2009-05-21 23:51:13 UTC
I have the same behaviour, I have worked around it for now using processing rules but of course that does mean I need to select another folder and then re-enter a news folder for the processing to trigger. > that does mean I need to select another folder and then
> re-enter a news folder for the processing to trigger.
... or using the folder context menu item, 'Run processing rules'
bug 2627 (dupe) comment 6 has a workaround that's infinitely preferable to using processing instead. Created attachment 1547 [details] [PATCH 1/2] fix nntp filtering on incoming messages this should fix bug #1920 and bug #2627 folder_item_scan_full() in folder.c at line 2343 applies filter only to folder items of special type F_INBOX. but nntp folder items are of special folder item type F_NORMAL and folder type F_NEWS. so i change the condition for do_filter to also match nntp folders. works for me on fedora 22 and claws-mail-3.11.1 Created attachment 1548 [details]
[PATCH 2/2] fix nntp manually filtering with account specific rules
manually running filter on nntp folders doesn't work correctly with
account specific rules. filtering_match_condition() in filtering.c:568
always gets a NULL as ac_prefs and every check with ac_prefs fails
subsequently. later cur_account is used instead, what is imo clearly
wrong and useless.
i have patched summaryview.c:5649 summary_filter() to extract the
account data from summaryview and hand over them as new parameter to
summary_filter_func().
works for me on fedora 22 and claws-mail-3.11.1
Both patches work for me, building using Gentoo's claws-mail-3.11.1-r1. Thanks, Stephan! These patches still apply to 3.13.0. Does "RESOLVED PATCHESWELCOME" mean someone on the Claws team might review them someday? The bug was closed as PATCHESWELCOME and has received patches, reopening. i've done a rebase no changes since last pull request available in the git repository at: https://github.com/stesachse/claws.git bz1920_no_automatic_nntp_filtering compare the changes at: https://github.com/stesachse/claws/compare/bz1920_no_automatic_nntp_filtering /me Both patches tested and pushed to git, (belated) thanks! :) |