Summary: | claws should make use of the IMAP 'deleted' flag | ||||||
---|---|---|---|---|---|---|---|
Product: | Claws Mail (GTK 2) | Reporter: | Vitus Jensen <vjensen> | ||||
Component: | Folders/IMAP | Assignee: | users | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | enhancement | CC: | pocallaghan | ||||
Priority: | P3 | ||||||
Version: | 3.7.1 | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Vitus Jensen
2009-03-07 17:36:18 UTC
Created attachment 664 [details]
patch to partly implement IMAP deletion modell
This patch
- removes the 'expunge' commands from message deletion
- adds a 'compress_folder' method to _FolderClass which does the 'expunge'
- implements GUI elements to show/hide deleted messages
There are still issues
- delete removes messages from view (open/close folder to see messages)
- no GUI element to compress folders
I agree with this proposal and urge its adoption, but would add that it would be even more useful if Claws supported a "virtual Trash" folder along the lines of Evolution. I can live without that though. Note that "undeleting" messages would now simply involve removing the \Deleted flag. Minor comment: the IMAP action for permanently removing mail is Expunge. "Compact folder" is an implementation-dependant synonym that makes literal sense when folders are stored as files but not otherwise; see for example several major IMAP servers such as Cyrus or Gmail. What I don't know is how moves between folders (which are copy+delete+expunge right now be handled). Copy+delete and no expunge? I have to say I hate this deletion-doesn't-delete model of IMAP. The patch will have to be great before I'd accept it :) Changes related to this bug have been committed. Please check latest CVS and update the bug accordingly. You can also get the patch from: http://www.colino.net/claws-mail/ 2009-03-30 [colin] 3.7.1cvs30 * src/folder.c * src/folder.h * src/imap.c * src/mainwindow.c * src/mainwindow.h * src/prefs_account.c * src/prefs_account.h * src/summaryview.c * src/summaryview.h Fix bug 1866, 'Claws should make use of the IMAP 'deleted' flag' Add an option on the Receive page of IMAP account preferences: "Move deleted mails to trash and expunge immediately". This option defaults to TRUE to avoid changing the existing behaviour. Setting it to FALSE prevents automatic expunging. Also, add Tools/Expunge and View/Hide deleted messages menu items (View/Hide deleted message being a per-folder setting, and behaving, like View/Hide read messages). Changes related to this bug have been committed. Please check latest CVS and update the bug accordingly. You can also get the patch from: http://www.colino.net/claws-mail/ 2009-03-30 [colin] 3.7.1cvs30 * src/folder.c * src/folder.h * src/imap.c * src/mainwindow.c * src/mainwindow.h * src/prefs_account.c * src/prefs_account.h * src/summaryview.c * src/summaryview.h Fix bug 1866, 'Claws should make use of the IMAP 'deleted' flag' Add an option on the Receive page of IMAP account preferences: "Move deleted mails to trash and expunge immediately". This option defaults to TRUE to avoid changing the existing behaviour. Setting it to FALSE prevents automatic expunging. Also, add Tools/Expunge and View/Hide deleted messages menu items (View/Hide deleted message being a per-folder setting, and behaving, like View/Hide read messages). Changes related to this bug have been committed. Please check latest CVS and update the bug accordingly. You can also get the patch from: http://www.colino.net/claws-mail/ 2009-03-30 [colin] 3.7.1cvs30 * src/folder.c * src/folder.h * src/imap.c * src/mainwindow.c * src/mainwindow.h * src/prefs_account.c * src/prefs_account.h * src/summaryview.c * src/summaryview.h Fix bug 1866, 'Claws should make use of the IMAP 'deleted' flag' Add an option on the Receive page of IMAP account preferences: "Move deleted mails to trash and expunge immediately". This option defaults to TRUE to avoid changing the existing behaviour. Setting it to FALSE prevents automatic expunging. Also, add Tools/Expunge and View/Hide deleted messages menu items (View/Hide deleted message being a per-folder setting, and behaving, like View/Hide read messages). 2009-03-30 [colin] 3.7.1cvs30 * src/folder.c * src/folder.h * src/imap.c * src/mainwindow.c * src/mainwindow.h * src/prefs_account.c * src/prefs_account.h * src/summaryview.c * src/summaryview.h Fix bug 1866, 'Claws should make use of the IMAP 'deleted' flag' Add an option on the Receive page of IMAP account preferences: "Move deleted mails to trash and expunge immediately". This option defaults to TRUE to avoid changing the existing behaviour. Setting it to FALSE prevents automatic expunging. Also, add Tools/Expunge and View/Hide deleted messages menu items (View/Hide deleted message being a per-folder setting, and behaving, like View/Hide read messages). |