Bug 1604

Created attachment 581 [details]
patch_one

Would you mind describing a simple scenario that would explain what you mean by "don't work", because it don't see what's wrong. And even with your patch applied (which sounds incomplete anyway) I see no behaviour change.

Note that by design the word "Any" has to remain untranslated (i.e. in en_US) in the condition string as well as when it's stored in the config file. "Any" is a reserved keyword in the matcher expression language. Otherwise it would not be possible to swap the locale and make the Condition Configuration dialog updated from the condition string correctly.

"don't work" == don't filtering

I'm make rule
(found_in_addressbook "From" in "Any" move #mh/mail/KNOWN)
and this is don't work. In log write - don't mathed,
in debug some GTK error.

_("Any") in my local return "Любой". And in some place don't work test:

if (action->destination == NULL ||
   strcasecmp(action->destination, _("Any")) == 0 ||
   *(action->destination) == '\0')
   path = NULL;

action->destination = "Any", but _("Any") = "Любой".

Excuse, now I very busy. I think this bug many users see.
Well, I write detailed later (~1 month). And my English very bad.

If who have some bug - write (found_in_addressbook "From" in "").

I see. What is your locale exactly? (output of the command `locale`)

> I see. What is your locale exactly? (output of the command `locale`)

LANG=ru_RU.UTF-8

And i think problem in this (or _("Any")):

ru.po:
msgid "Any"
msgstr "Любой"

fr.po:
msgid "Any"
msgstr "Quelconque"

Of course, Любой == Luboy in russian.
This site don't correctly output UTF.

Created attachment 582 [details]
patch rev1 (core and core plugins)

Created attachment 583 [details]
patch rev1 (non-core plug-ins)

Here's a patch candidate (rev1), would you mind testing it please? It's based on your patch, slightly modified (use of g_utf8_collate when comparing _("Any") is necessary, also fixes comparing header "All"), including plug-ins changes.

Yes, work. But I use claws-mail and trayicon only. Not other
plugins (spam don't disturb).
And on bogofilter patch that say:

patching file src/plugins/bogofilter/bogofilter.c
Hunk #1 succeeded at 214 (offset -2 lines).
patching file src/plugins/bogofilter/bogofilter_gtk.c
Hunk #1 FAILED at 299.
Hunk #2 succeeded at 365 with fuzz 2 (offset -12 lines).
1 out of 2 hunks FAILED -- saving rejects to file src/plugins/bogofilter/bogofilter_gtk.c.rej

Because my version of src 3.3.1.
In other respects there are normal, work.
I make, edit and test new rule with found_in_addresbook.

---

And some more. In editor "found_in_addresbook" value of field "Header"
are untranslate. I'm not how true:
prefs_matcher.c 652
	header_addr_combo = combobox_text_new(TRUE,
			      Q_("Filtering Matcher Menu|All"), _("Any"),
			      "From", "To", "Cc", "Reply-To", "Sender", NULL);

Oh, Stop! This is add new bug. Some time later.

Thanks for testing, patch will land to CVS soon.

And for:

> And some more. In editor "found_in_addresbook" value of field "Header"
> are untranslate. I'm not how true:
> prefs_matcher.c 652
>         header_addr_combo = combobox_text_new(TRUE,
>                               Q_("Filtering Matcher Menu|All"), _("Any"),
>                               "From", "To", "Cc", "Reply-To", "Sender", NULL);
> 
> Oh, Stop! This is add new bug. Some time later.

yes a new bug is welcome but keep in mind that only "All" and "Any" will be translated, not "From" and other header values.